Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safely optional #73

Closed
wants to merge 6 commits into from
Closed
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
PATH
remote: .
specs:
daemon-kit (0.3.0.rc1)
daemon-kit (0.3.0.rc2)
eventmachine (>= 0.12.10)
i18n
safely (>= 0.3.1)
thor

GEM
Expand Down Expand Up @@ -59,3 +58,4 @@ DEPENDENCIES
rake
rdoc
rspec (~> 2.6)
safely (~> 0.3.2)
2 changes: 1 addition & 1 deletion daemon-kit.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,9 @@ $ daemon-kit -h
gem.add_development_dependency(%q<cucumber>, ["~> 1.3.8"])
gem.add_development_dependency(%q<aruba>, ["~> 0.5.3"])
gem.add_development_dependency(%q<SyslogLogger>)
gem.add_development_dependency(%q<safely>, ["~> 0.3.2"])

gem.add_dependency(%q<thor>)
gem.add_runtime_dependency(%q<eventmachine>, [">= 0.12.10"])
gem.add_runtime_dependency(%q<safely>, [">= 0.3.1"])
gem.add_runtime_dependency(%q<i18n>)
end
15 changes: 10 additions & 5 deletions lib/daemon_kit/initializer.rb
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@
$LOAD_PATH.include?( File.expand_path('../', __FILE__).to_absolute_path )

require 'daemon_kit'
require 'safely'

module DaemonKit

class << self
Expand Down Expand Up @@ -206,10 +204,17 @@ def include_core_lib
def configure_safely
Thread.abort_on_exception = true

Safely::Strategy::Log.logger = DaemonKit.logger
if defined? Safely
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely needs specs as per @marcbowes instructions

DaemonKit.logger.info "Configuring safely for exception handling"
Safely::Strategy::Log.logger = DaemonKit.logger

Safely::Backtrace.trace_directory = File.join( DAEMON_ROOT, "log" )
Safely::Backtrace.enable!

Safely::Backtrace.trace_directory = File.join( DAEMON_ROOT, "log" )
Safely::Backtrace.enable!
else
DaemonKit.logger.info "Safely not available, remember to implement good exception handling"

end
end

def set_process_name
Expand Down
12 changes: 11 additions & 1 deletion lib/daemon_kit/ruote_participants.rb
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,8 @@ def run_amqp!

cmdq = mq.queue( q, :durable => true )
cmdq.subscribe( :ack => true ) do |header, message|
safely do

receiver = lambda do |header, message|
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely needs specs as per @marcbowes instructions

DaemonKit.logger.debug("Received workitem: #{message.inspect}")

RuoteWorkitem.process( :amqp, @amqp_reply_queue, message )
Expand All @@ -114,6 +115,15 @@ def run_amqp!

header.ack
end

if defined? Safely
safely { receiver.call( header, message ) }

else
receiver.call( header, message )

end

end
end
end
Expand Down
4 changes: 3 additions & 1 deletion lib/daemon_kit/version.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
module DaemonKit

def version
'0.3.0.rc1'
'0.3.0.rc2'
end

module_function :version
end
6 changes: 5 additions & 1 deletion lib/generators/daemon_kit/app/templates/Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,11 @@ source 'https://rubygems.org'
# daemon-kit
gem 'daemon-kit'

#
# safely (http://github.com/kennethkalmer/safely)
gem 'safely'
#

gem 'safely' # Optional, but recommended.

# gem 'toadhopper' # For reporting exceptions to hoptoad
# gem 'mail' # For reporting exceptions via mail