Middleware

[tomchristie]

Supporting ASGI middleware would be a really good way to compartmentalise away bits of complexity, as we all promoting more of a cross-framework ecosystem.

I'd suggest an interface of app.add_middleware(cls, **options)

We could then do things like:

• Move the GZip handling out of Response, and use Starlette's GzipMiddleware, which will also take care of handling streaming responses (once responder has those)
• Be able to use Starlette's CORSMiddleware.

We can set up a default set of middleware if needed based on the configuration options presented to the API(...) class.

Any objections or considerations?

[kennethreitz]

I'm open to that:

    def add_middleware(self, middleware_class, **options):
        self.middleware.append(middleware_class(self, **options))

[tomchristie]

Also useful here - Starlette's ExceptionMiddleware

[ajitid]

Hey, any idea how to turn on debug mode in Responder?

[kennethreitz]

@ajitid it doesn't have it yet :)

[tomchristie]

Run it using uvicorn --debug example:app and you'll get in-browser tracebacks on exceptions and auto-reloading.

uvicorn.run(..., debug=True) is the equivalent thing programmatically, and will give you in-browser tracebacks, but isn't able to do auto-reloads.

[ajitid]

The reloader is not enabled when running programmatically.

Didn't knew this, and got confused.