Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form is not saved #48

Closed
VincentSC opened this issue Nov 29, 2021 · 13 comments · Fixed by #49
Closed

Form is not saved #48

VincentSC opened this issue Nov 29, 2021 · 13 comments · Fixed by #49

Comments

@VincentSC
Copy link

All data under tab “API Integration” is not being saved. I tried different browsers, but all I got was “Contact form saved” and an empty form.

What could be the cause? “max_input_vars” is 1000.

@mooksz
Copy link

mooksz commented Nov 29, 2021

Same

@VincentSC
Copy link
Author

Putting it to 10000 did not work. https://wordpress.org/support/topic/form-is-not-saved/

@BurakBoz
Copy link

BurakBoz commented Dec 1, 2021

Same issue here. Nothing is saved any suggestions?

@eashman
Copy link

eashman commented Dec 1, 2021

Same for me - it can be fixed temporarily by downgrading to Contact Form 7 v5.5.2 -- it appears some change in 5.5.3 is what broke this.

https://wordpress.org/plugins/contact-form-7/advanced/ and scroll to the bottom to get to older versions of the form plugin.

@VincentSC
Copy link
Author

I can confirm this works. As suddenly test-data showed up, I assume the data is actually saved but not shown in the form.

@AllCdnBoy
Copy link

WP has a plugin called "Rollback" which made the process of rolling back nice and easy. I think if you haven't tried to re-save the API details, they will come back when you rollback

@VincentSC
Copy link
Author

No need for that plugin. By manually uploading the old version, it also rolls back without problems.

I can say that the plugin stops working after an update to 5.5.3. So it needs to be held at 5.5.2 until this is fixed.

@AllCdnBoy
Copy link

Doesn't appear to always be the case. The was the first thing I tried and it said "This plugin already exists"

@VincentSC
Copy link
Author

Click "Replace current with uploaded"

image

@AllCdnBoy
Copy link

I don't have those options. It goes from this:
image

to this:

image

@VincentSC
Copy link
Author

Weird. No sure why there is a difference, assuming you also have the latest Wordpress version.

About this bug. When I've done my taxes, I'll spend some time to debug the problem. I found another plugin who had the same problem, so it can be done by example. If you cannot wait for my taxes, please be my guest. :)

https://wordpress.org/support/topic/the-plugin-isnt-working-with-new-version-of-cf7/
https://github.com/mariovalney/cf7-to-zapier

Main problem is to get a PR accepted, as maintenance is not really done here

@VincentSC
Copy link
Author

VincentSC commented Dec 5, 2021

Fixed! (yes, finished taxes)

Add one line to includes/class-cf7-api-admin.php on line 82, after add_filter( "wpcf7_contact_form_properties" ,array( $this , "add_sf_properties" ) , 10 , 2 );:

	add_filter( 'wpcf7_pre_construct_contact_form_properties', array( $this, 'add_sf_properties' ), 10, 2 );

That's all.

I'm not at my dev-machine, so cannot easily create a PR. So if you want it fixed now, you need to manually edit that file. I've already contacted the author some days ago, but did not get a response yet.

(all credit goes to @mariovalney, as he figured things out)

@mariovalney
Copy link
Contributor

mariovalney commented Dec 5, 2021

Thanks for the props @VincentSC :)

Actually the answer is in CF7 release post. The problem is CF7 seems to do not follow semantic versioning and introduced a breaking change.

I've made the PR #49 to fixes it.

@kennym kennym closed this as completed in #49 Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants