Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuration.FromXDocument cast bug #16

Closed
kentcb opened this issue Sep 9, 2015 · 0 comments
Closed

Configuration.FromXDocument cast bug #16

kentcb opened this issue Sep 9, 2015 · 0 comments
Labels
bug

Comments

@kentcb
Copy link
Owner

kentcb commented Sep 9, 2015

The Configuration.FromXDocument method includes a call to Cast. This can fail when comments are interspersed amongst the XML elements. OfType should be used instead.
@kentcb kentcb added the bug label Sep 9, 2015
@kentcb kentcb closed this as completed in 67df40a Sep 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kentcb