Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profiler API #51

Closed
nkabbara opened this issue May 12, 2020 · 2 comments
Closed

Profiler API #51

nkabbara opened this issue May 12, 2020 · 2 comments

Comments

@nkabbara
Copy link

nkabbara commented May 12, 2020 •
edited
Loading

Hi @kentcdodds

In branch 09, the custom Profiler component api is expecting metadata, but around the app, data prop is being passed instead.

API:

bookshelf/src/components/profiler.extra-3.js

Line 20 in c677162

function Profiler({metadata, phases, ...props}) {

Around app:

bookshelf/src/screens/book.extra-3.js

Line 28 in c677162

<Profiler id="Book Screen" data={{bookId, listItemId: listItem?.id}}>

-Nash
@kentcdodds
Copy link
Owner

Ah, thank you Nash! I'll get that fixed up.

@kentcdodds
Copy link
Owner

Pushed the fix just now. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nkabbara @kentcdodds