Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-commit] Fails when passing environment to test script #105

Open
MichaelDeBoey opened this issue Nov 27, 2019 · 1 comment
Open

[pre-commit] Fails when passing environment to test script #105

MichaelDeBoey opened this issue Nov 27, 2019 · 1 comment

Comments

@MichaelDeBoey
Copy link
Contributor

When having your test script with a set environment (--env=jsdom) as we have with geniejs, the pre-commit script will fail as this will run kcd-scripts test --findRelatedTests and doesn't take these extra variables into account

"test": "kcd-scripts test --env=jsdom",

https://github.com/kentcdodds/genie/blob/b2aec0a8ea9bf1a0d85fead0427dcb1a1dcee7c8/package.json#L26

@kentcdodds
Copy link
Owner

I'm not sure how to fix this generally, but I'd suggest just making geniejs have a custom jest config to set the env manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants