Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Jest to 29.x and drop support for Node.js 12.x #233

Merged
merged 2 commits into from
Jan 28, 2023

Conversation

eps1lon
Copy link
Contributor

@eps1lon eps1lon commented Jan 28, 2023

BREAKING CHANGE: Drops support for Node.js 12x. Updates Jest to 29.x

Needs update for required GH checks (since 12.x is no longer tested)

What:

Drops support for Node.js 12x. Updates Jest to 29.x

Why:

Updating Jest to 29.x pulls in JSDOM 20.x which no longer supports Node.js 12.x

How:

Bump dependencies from the Jest monorepo and update snapshots

Checklist:

  • Documentation
  • Tests
  • Ready to be merged

@codecov
Copy link

codecov bot commented Jan 28, 2023

Codecov Report

Merging #233 (0e8a588) into main (ce96bf4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #233   +/-   ##
=======================================
  Coverage   63.33%   63.33%           
=======================================
  Files          21       21           
  Lines         600      600           
  Branches      227      227           
=======================================
  Hits          380      380           
  Misses        179      179           
  Partials       41       41           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@eps1lon eps1lon marked this pull request as ready for review January 28, 2023 10:07
Copy link
Owner

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid. Thanks!

@kentcdodds kentcdodds merged commit d7d25b0 into kentcdodds:main Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants