Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add awesome-nlp to awesome.re? #84

Closed
NirantK opened this issue Jan 3, 2018 · 19 comments
Closed

Add awesome-nlp to awesome.re? #84

NirantK opened this issue Jan 3, 2018 · 19 comments

Comments

@NirantK
Copy link
Collaborator

NirantK commented Jan 3, 2018

Awesome.re is a meta-list of awesome repositories.

It has a few guidelines to be included there.
Maybe we can use that as our checklist to improve this. And then raise a PR when we are done?

What do you suggest @keon ?

@keon
Copy link
Owner

keon commented Jan 3, 2018

sounds good! In fact, I was going to do that a long time ago (sindresorhus/awesome#677) but got too busy for a while.

also, for long term...
I wanted to work on a script that allows us to store the lists in some sort of json or list that could automatically be used for parsing, verifying the url, and generating the README.md.

@NirantK
Copy link
Collaborator Author

NirantK commented Jan 3, 2018

The script sounds like a good idea:

  • make our jobs easier as maintainers
  • does it make it more difficult to contribute to README.md then write now?
    Keeping in mind that most contributors are contributing directly from their browsers.

Maybe we should add that script to a Pull Request hook? Include formatting checks in the script itself - similar to Bandit for code?

@NirantK
Copy link
Collaborator Author

NirantK commented Jan 9, 2018

@keon just following up, do you have any more inputs on what we want from the json2md (json to markdown) script?

@NirantK
Copy link
Collaborator Author

NirantK commented Mar 5, 2018

@the-ethan-hunt would you like to take lead on this and guide us on what we need to get done to add awesome-nlp to awesome.re?

@the-ethan-hunt
Copy link
Collaborator

@NirantK , I find that awesome-nlp has all the required stuff to be included in the awesome.re list. Should we pull a request? Or maybe @keon should(He is the original maintainer of the project 😄 )?

@NirantK
Copy link
Collaborator Author

NirantK commented Mar 5, 2018

Let's not wait for @keon. Please raise a PR there. Please double check that we are visible in a separate section.

Preferably not absorbed under wider and less maintained Speech and Natural Language Processing sections ;)

I'd like for people to find us as easily as possible.

@the-ethan-hunt
Copy link
Collaborator

Includes a project logo/illustration whenever possible.

We might be lagging here. any suggestions on how to proceed on this? 😅

@NirantK
Copy link
Collaborator Author

NirantK commented Mar 5, 2018

Hmm, I had looked at a few examples back in January. We'll probably start with a cover image as in #94 and then just ask the awesome.re maintainer for advice.

Adding section specific images would ruin the repo organization and make it longer than it already is.

@the-ethan-hunt
Copy link
Collaborator

How about pulling a request here about the cover image ideas you had and then we can decide the appropriate image?

@NirantK
Copy link
Collaborator Author

NirantK commented Mar 5, 2018

Good idea, I will raise a PR for it.

Since this is going to take some time from my end, anything else other than that we need to do?

@the-ethan-hunt
Copy link
Collaborator

Nope,not at all
Secondly, @keon raised this issue here
The maintainer has asked about the status of our list(a year ago). Is it wise to reply back now with an apology? 😄

@NirantK
Copy link
Collaborator Author

NirantK commented Mar 5, 2018

Thanks for bringing that to notice. I somehow missed that completely.

Sure, please go ahead and tell @sindresorhus that we are helping keon maintain this.

And we would like to include the list as we've updated (and expanded) it significantly over last 4-6 months.

@the-ethan-hunt
Copy link
Collaborator

Done! All we need to do is wait for his comment while we plan out a cover image.

@NirantK
Copy link
Collaborator Author

NirantK commented Mar 5, 2018 via email

@NirantK
Copy link
Collaborator Author

NirantK commented Mar 12, 2018

@the-ethan-hunt please follow up?

@the-ethan-hunt
Copy link
Collaborator

@NirantK , @keon created a new issue here, see. We are still waiting for a response from the maintainers of the awesome.re project

@the-ethan-hunt
Copy link
Collaborator

@NirantK , there has been no fresh leads on the issue. Any ideas to proceed further?

@NirantK
Copy link
Collaborator Author

NirantK commented Jun 30, 2018

No, have stopped pursuing this. There has been no response on the old and new issues by the repo maintainer there.

We can try to raise a clean PR to that repo as per the new issue and see if that get's accepted.

Else, close this issue please

@the-ethan-hunt
Copy link
Collaborator

Sure. But before submitting another PR, we should maybe have a cover image first. Closing this issue nonetheless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants