-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add awesome-nlp to awesome.re? #84
Comments
sounds good! In fact, I was going to do that a long time ago (sindresorhus/awesome#677) but got too busy for a while. also, for long term... |
The script sounds like a good idea:
Maybe we should add that script to a Pull Request hook? Include formatting checks in the script itself - similar to Bandit for code? |
@keon just following up, do you have any more inputs on what we want from the |
@the-ethan-hunt would you like to take lead on this and guide us on what we need to get done to add awesome-nlp to awesome.re? |
Let's not wait for @keon. Please raise a PR there. Please double check that we are visible in a separate section. Preferably not absorbed under wider and less maintained Speech and Natural Language Processing sections ;) I'd like for people to find us as easily as possible. |
We might be lagging here. any suggestions on how to proceed on this? 😅 |
Hmm, I had looked at a few examples back in January. We'll probably start with a cover image as in #94 and then just ask the awesome.re maintainer for advice. Adding section specific images would ruin the repo organization and make it longer than it already is. |
How about pulling a request here about the cover image ideas you had and then we can decide the appropriate image? |
Good idea, I will raise a PR for it. Since this is going to take some time from my end, anything else other than that we need to do? |
Thanks for bringing that to notice. I somehow missed that completely. Sure, please go ahead and tell @sindresorhus that we are helping keon maintain this. And we would like to include the list as we've updated (and expanded) it significantly over last 4-6 months. |
Done! All we need to do is wait for his comment while we plan out a cover image. |
Sounds good. Thanks!
…On 5 Mar 2018 11:00 pm, "Dhruv Apte" ***@***.***> wrote:
Done! All we need to do is wait for his comment while we plan out a cover
image.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#84 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADGaPXIY2fqDfoVxDG1eLkdgY1eMEueKks5tbXY8gaJpZM4RRRiS>
.
|
@the-ethan-hunt please follow up? |
@NirantK , there has been no fresh leads on the issue. Any ideas to proceed further? |
No, have stopped pursuing this. There has been no response on the old and new issues by the repo maintainer there. We can try to raise a clean PR to that repo as per the new issue and see if that get's accepted. Else, close this issue please |
Sure. But before submitting another PR, we should maybe have a cover image first. Closing this issue nonetheless. |
Awesome.re is a meta-list of awesome repositories.
It has a few guidelines to be included there.
Maybe we can use that as our checklist to improve this. And then raise a PR when we are done?
What do you suggest @keon ?
The text was updated successfully, but these errors were encountered: