Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings in .ini #20

Closed
remb0 opened this issue Sep 21, 2016 · 3 comments
Closed

Settings in .ini #20

remb0 opened this issue Sep 21, 2016 · 3 comments

Comments

@remb0
Copy link

remb0 commented Sep 21, 2016

IN BS440domoticz.py
unit Hardwareid and unit are hardcoded. can this be placed in the ini?

the same for google auth disable/enable.
when not using google, bs440 will import bs440google always, even when not using.

@keptenkurk
Copy link
Owner

keptenkurk commented Sep 21, 2016

Could you enlighten us on the purpose of these ID's. No problem to get these from the .ini
Do we need to take care of not creating a virtual sensor with a conflicting ID? Limited Domoticz knowledge causes me being in the dark here.

@remb0
Copy link
Author

remb0 commented Sep 21, 2016

in domoticz.py you use:
url = 'http://%s/json.htm?type=command&param=udevice&hid=13&'
'did=%s&dunit=4&dtype=93&dsubtype=1&nvalue=0&svalue=%s' % (

but the hid and unitid can for every user different. and you have a great ini file to be modulair, so it would better to use the ini for this parameters to be more flexible.

@keptenkurk
Copy link
Owner

Added feature in commit c140a5c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants