Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

chore: Remove unneeded code #490

Merged
merged 3 commits into from
Jul 7, 2022
Merged

chore: Remove unneeded code #490

merged 3 commits into from
Jul 7, 2022

Conversation

arthurpitman
Copy link
Contributor

@arthurpitman
Remove unused functions
5db00a9 
Signed-off-by: Arthur Pitman <arthur.pitman@dynatrace.com>
@arthurpitman
Deduplicate constant
be85c90 
Signed-off-by: Arthur Pitman <arthur.pitman@dynatrace.com>
@arthurpitman
Remove unneeded fmt.Println calls
b37b7ae 
Signed-off-by: Arthur Pitman <arthur.pitman@dynatrace.com>
@arthurpitman arthurpitman requested a review from warber July 1, 2022 11:00
@sonarcloud
Copy link

sonarcloud bot commented Jul 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

christian-kreuzberger-dtx
christian-kreuzberger-dtx approved these changes Jul 7, 2022
View reviewed changes
Copy link
Member

@christian-kreuzberger-dtx christian-kreuzberger-dtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - though let's also get a review from @warber or @bacherfl or @RealAnna

RealAnna
RealAnna approved these changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@RealAnna RealAnna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too!

@warber warber merged commit d00898a into master Jul 7, 2022
@warber warber deleted the chore/clean-up-unneeded-code branch July 7, 2022 09:44
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@christian-kreuzberger-dtx christian-kreuzberger-dtx christian-kreuzberger-dtx approved these changes

@warber warber warber approved these changes

@RealAnna RealAnna RealAnna approved these changes

@bacherfl bacherfl Awaiting requested review from bacherfl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arthurpitman @christian-kreuzberger-dtx @warber @RealAnna