fix(shipyard-controller): Consider parallel stages when trying to set…

… overall sequence state to finished (#7237)

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>

shipyard-controller/handler/sequencehooks/sequencestate.go

@@ -235,6 +235,15 @@ func (smv *SequenceStateMaterializedView) updateOverallSequenceState(eventScope
 		return
 	}
 
+	// if the sequence should be set to 'finished'  we need to ensure that all sequences in all stages are finished
+	if status == models.SequenceFinished {
+		for index := range state.Stages {
+			// if we still have an unfinished stage, we can not set the overall sequence state to 'finished'
+			if state.Stages[index].State == models.SequenceTriggeredState {
+				return
+			}
+		}
+	}
 	state.State = status
 	if err := smv.SequenceStateRepo.UpdateSequenceState(*state); err != nil {
 		log.Errorf("could not update sequence state: %s", err.Error())

shipyard-controller/handler/sequencehooks/sequencestate_test.go

@@ -228,7 +228,16 @@ func TestSequenceStateMaterializedView_OnSequenceFinished(t *testing.T) {
 									Project:        "my-project",
 									Shkeptncontext: "my-context",
 									State:          "triggered",
-									Stages:         nil,
+									Stages: []models.SequenceStateStage{
+										{
+											Name:  "dev",
+											State: "succeeded",
+										},
+										{
+											Name:  "dev",
+											State: "succeeded",
+										},
+									},
 								},
 							},
 						}, nil
@@ -251,6 +260,51 @@ func TestSequenceStateMaterializedView_OnSequenceFinished(t *testing.T) {
 			},
 			expectUpdateToBeCalled: true,
 		},
+		{
+			name: "try to finish sequence - not all stages finished yet",
+			fields: SequenceStateMVTestFields{
+				SequenceStateRepo: &db_mock.SequenceStateRepoMock{
+					FindSequenceStatesFunc: func(filter models.StateFilter) (*models.SequenceStates, error) {
+						return &models.SequenceStates{
+							States: []models.SequenceState{
+								{
+									Name:           "my-sequence",
+									Service:        "my-service",
+									Project:        "my-project",
+									Shkeptncontext: "my-context",
+									State:          "triggered",
+									Stages: []models.SequenceStateStage{
+										{
+											Name:  "dev",
+											State: "succeeded",
+										},
+										{
+											Name:  "dev",
+											State: "triggered",
+										},
+									},
+								},
+							},
+						}, nil
+					},
+					UpdateSequenceStateFunc: func(state models.SequenceState) error {
+						return nil
+					},
+				},
+			},
+			args: args{
+				event: models.Event{
+					Data: keptnv2.EventData{
+						Project: "my-project",
+						Stage:   "my-stage",
+						Service: "my-service",
+					},
+					Shkeptncontext: "my-context",
+					Type:           common.Stringp("my-type"),
+				},
+			},
+			expectUpdateToBeCalled: false,
+		},
 		{
 			name: "invalid event scope - do not update",
 			fields: SequenceStateMVTestFields{