fix(resource-service): Remove token enforcement (#8040) (#8206)

keptn · Jun 27, 2022 · 6585037 · 6585037
1 parent 8e95da1
commit 6585037
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 7 deletions.
diff --git a/resource-service/common/credentials_test.go b/resource-service/common/credentials_test.go
@@ -76,9 +76,8 @@ func TestK8sCredentialReader_ReadSecretNoToken(t *testing.T) {
 	))
 
 	secret, err := secretReader.GetCredentials("my-project")
-
-	require.ErrorIs(t, err, errors.ErrCredentialsTokenMustNotBeEmpty)
-	require.Nil(t, secret)
+	require.Nil(t, err)
+	require.NotNil(t, secret)
 }
 
 func TestK8sCredentialReader_ReadSecretNoPrivateKey(t *testing.T) {

diff --git a/resource-service/common_models/git.go b/resource-service/common_models/git.go
@@ -65,8 +65,5 @@ func (g GitCredentials) validateRemoteURIAndToken() error {
 	if err != nil {
 		return kerrors.ErrCredentialsInvalidRemoteURI
 	}
-	if g.Token == "" {
-		return kerrors.ErrCredentialsTokenMustNotBeEmpty
-	}
 	return nil
 }
diff --git a/resource-service/common_models/git_test.go b/resource-service/common_models/git_test.go
@@ -32,7 +32,7 @@ func TestGitCredentials_Validate(t *testing.T) {
 				Token:     "",
 				RemoteURI: "https://my-repo",
 			},
-			wantErr: true,
+			wantErr: false,
 		},
 		{
 			name: "invalid URI",