Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

Keptn Bridge: Root events are limited to 20 #3223

Closed
1 of 12 tasks
GustavAT opened this issue Feb 10, 2021 · 1 comment · Fixed by #3333
Closed
1 of 12 tasks

Keptn Bridge: Root events are limited to 20 #3223

GustavAT opened this issue Feb 10, 2021 · 1 comment · Fixed by #3333
Assignees
@ermin-muratovic
Labels
bridge.2.0 Bridge Version 2 estimate: 0.5 performance
Projects
Working items
Milestone
0.8.0 (Bridge)

Comments

@GustavAT
Copy link

GustavAT commented Feb 10, 2021 •
edited

Environment

  • Client OS (e.g., Linux, OSX, Windows): Ubuntu 20.04
  • Keptn Version (keptn version): 0.8.0-alpha
  • Kubernetes Cloud Provider (e.g., GKE, AKS): GKE
  • Kubernetes version (kubectl version): v1.16.15-gke.6000
  • Bridge image: bridge2:0.8.0-dev-PR-3169

Affected Component

  • Docs
  • CLI
  • Kubernetes Integration
  • Openshift Integration
  • Helm
  • Istio
  • Bridge
  • Gatekeeper
  • Datastore
  • REST API
  • eventbroker / distributor
  • jmeter

Describe the bug

The Keptn Bidge initially only loads the latest 20 root events per project.

Example request:

/api/mongodb-datastore/event?root=true&pageSize=20&project=foobar

Example response (20 root events but 28 in total):

events: [,…]
nextPageKey: "20"
pageSize: 20
totalCount: 28

In this case, 8 root events are missing.
This could lead to certain service having no event-feeds at all.
This also causes missing approval confirmations in the environments screen. They can still be approved via the CLI.

Expected behavior

My suggestion: Last X root events could be loaded for each service

Current behavior

Last 20 root events are loaded per project.

fyi @ermin-muratovic
@johannes-b johannes-b added the bridge.2.0 Bridge Version 2 label Feb 10, 2021
@johannes-b johannes-b modified the milestones: 0.8.1, 0.8.1 (Bridge) Feb 10, 2021
@johannes-b johannes-b added ready-for-refinement Issue is relevant for the next backlog refinment estimate: 0.5 and removed ready-for-refinement Issue is relevant for the next backlog refinment labels Feb 16, 2021
@johannes-b
Copy link
Member

Will be addressed by #3224

@ermin-muratovic ermin-muratovic self-assigned this Feb 17, 2021
@ermin-muratovic ermin-muratovic added this to Backlog in Working items via automation Feb 17, 2021
@ermin-muratovic ermin-muratovic moved this from Backlog to In progress in Working items Feb 17, 2021
This was referenced Feb 17, 2021
Closed
Merged
@ermin-muratovic ermin-muratovic moved this from In progress to Ready for review in Working items Feb 22, 2021
ermin-muratovic added a commit that referenced this issue Feb 23, 2021
@ermin-muratovic
#3223 Load root events per Service (#3333)
76418b3 
* take services from GET /project response (no separate API calls needed) and load root events per service

Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>

* set contextId from params.shkeptncontext

Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>
@johannes-b johannes-b moved this from Ready for review to Done/presented in community review (column will be cleaned regularly) in Working items Feb 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ermin-muratovic ermin-muratovic

Labels
bridge.2.0 Bridge Version 2 estimate: 0.5 performance
Projects
No open projects
Working items
Done/presented in community review (c...
Milestone
0.8.0 (Bridge)
Development

Successfully merging a pull request may close this issue.

#3223 Load root events per Service keptn/keptn
3 participants
@johannes-b @ermin-muratovic @GustavAT