Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

Keptn API: Endpoint is missing path parameter and mismatch between parameter name #3489

Closed
johannes-b opened this issue Mar 10, 2021 · 0 comments · Fixed by #3494 or #3502
Closed

Keptn API: Endpoint is missing path parameter and mismatch between parameter name #3489

johannes-b opened this issue Mar 10, 2021 · 0 comments · Fixed by #3494 or #3502
Assignees
@warber
Labels
area:api type:bug Something is not working as intended/documented
Projects
Sprint 214 [26/2 - 12/3]
Milestone
0.8.1

Comments

@johannes-b
Copy link
Member

johannes-b commented Mar 10, 2021 •
edited

The Keptn API for the shipyard-controller has two bugs as shown below. In course of fixing this bug, please do a sanity check of the other endpoints.

Missing path parameter

image

  • Fix: Double-check with implementation, but I assume that stage is missing in the URL

Mismatch between naming

image

  • Fix: Streamlined with the other endpoints
@johannes-b johannes-b added type:bug Something is not working as intended/documented area:api labels Mar 10, 2021
@johannes-b johannes-b added this to To Do in Sprint 214 [26/2 - 12/3] via automation Mar 10, 2021
@warber warber moved this from To Do to In progress in Sprint 214 [26/2 - 12/3] Mar 10, 2021
@warber warber self-assigned this Mar 10, 2021
warber added a commit that referenced this issue Mar 10, 2021
@warber
#3489: fixed swagger doc
b3aa1f0 
Signed-off-by: warber <bernd.warmuth@dynatrace.com>
@warber warber mentioned this issue Mar 10, 2021
Merged
@warber warber moved this from In progress to Ready for review in Sprint 214 [26/2 - 12/3] Mar 10, 2021
warber added a commit that referenced this issue Mar 10, 2021
@warber
#3489: fixed swagger doc (#3494)
9e988cb 
Signed-off-by: warber <bernd.warmuth@dynatrace.com>
warber added a commit that referenced this issue Mar 10, 2021
@warber
Revert "#3489: fixed swagger doc (#3494)"
66e4a5d 
This reverts commit 9e988cb.

Signed-off-by: warber <bernd.warmuth@dynatrace.com>
@warber warber moved this from Ready for review to In progress in Sprint 214 [26/2 - 12/3] Mar 10, 2021
warber added a commit that referenced this issue Mar 10, 2021
@warber
Merge pull request #3501 from keptn/revert-3494-patch/3489/sanitize-a…
f5c31b4 
…pi-endpoints

Revert "#3489: fixed swagger doc"
@warber warber mentioned this issue Mar 10, 2021
Merged
@johannes-b johannes-b reopened this Mar 10, 2021
warber added a commit that referenced this issue Mar 11, 2021
@warber
#3489: added temporary trigger for doing docker login at workflow dis…
de67329 
…patch

Signed-off-by: warber <bernd.warmuth@dynatrace.com>
warber added a commit that referenced this issue Mar 11, 2021
@warber
#3489: added trigger for doing docker login at workflow dispatch
da16ad2 
Signed-off-by: warber <bernd.warmuth@dynatrace.com>
warber added a commit that referenced this issue Mar 11, 2021
@warber
#3489: removed temporary trigger for doing docker login at workflow d…
a370d31 
…ispatch

Signed-off-by: warber <bernd.warmuth@dynatrace.com>
christian-kreuzberger-dtx added a commit that referenced this issue Mar 11, 2021
@christian-kreuzberger-dtx
Merge pull request #3510 from keptn/patch/ci-docker-login-on-workflow…
cc92dd4 
…-dispatch

#3489: added trigger for doing docker login at workflow dispatch
warber added a commit that referenced this issue Mar 11, 2021
@warber
Merge pull request #3502 from keptn/patch/3489/sanitize-api-endpoints
141ee82 
#3489: fixed swagger doc
@warber warber moved this from In progress to Done in Sprint 214 [26/2 - 12/3] Mar 11, 2021
@johannes-b johannes-b modified the milestones: 0.8.2, 0.8.1 Mar 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@warber warber

Labels
area:api type:bug Something is not working as intended/documented
Projects
No open projects
Sprint 214 [26/2 - 12/3]
Done
Milestone
0.8.1
Development

Successfully merging a pull request may close this issue.

#3489: fixed swagger doc keptn/keptn
#3489: fixed swagger doc keptn/keptn
2 participants
@johannes-b @warber