Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

fix(mongodb-datastore): added dedicated get endpoint for readiness probe #5499

Merged
merged 2 commits into from
Oct 5, 2021
Merged

fix(mongodb-datastore): added dedicated get endpoint for readiness probe #5499

merged 2 commits into from
Oct 5, 2021

Conversation

warber
Copy link
Contributor

@warber warber commented Oct 5, 2021

fixes #5476

@warber
added dedicated get endpoint for readiness probe
fa38f88 
Signed-off-by: warber <bernd.warmuth@dynatrace.com>
@warber warber added the CI:trigger-build-everything Trigger CI Build: Set BUILD_EVERYTHING=TRUE label Oct 5, 2021
@warber warber requested a review from a team as a code owner October 5, 2021 11:23
@codecov
Copy link

codecov bot commented Oct 5, 2021 •
edited
Loading

Codecov Report

Merging #5499 (19a222e) into master (711c43e) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 19a222e differs from pull request most recent head 0823c08. Consider uploading reports for the commit 0823c08 to get more accurate results

@@            Coverage Diff             @@
##           master    #5499      +/-   ##
==========================================
- Coverage   54.71%   54.69%   -0.03%     
==========================================
  Files         319      319              
  Lines       18571    18571              
  Branches      929      929              
==========================================
- Hits        10161    10157       -4     
- Misses       7506     7513       +7     
+ Partials      904      901       -3
Impacted Files Coverage Δ
platform-support/openshift-route-service/main.go 25.33% <0.00%> (-9.34%) ⬇️
distributor/pkg/lib/controlplane/uniformlog.go 79.62% <0.00%> (+5.55%) ⬆️

@warber
register new endpoint
0823c08 
Signed-off-by: warber <bernd.warmuth@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 5, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2021 •
edited
Loading

Docker Build Report

  • Retagged unchanged image keptn/approval-service with keptn/approval-service:0.9.3-dev-PR-5499.202110051249 and keptn/approval-service:0.9.3-dev-PR-5499 (Source: approval-service/)
  • Retagged unchanged image keptn/distributor with keptn/distributor:0.9.3-dev-PR-5499.202110051249 and keptn/distributor:0.9.3-dev-PR-5499 (Source: distributor/)
  • Retagged unchanged image keptn/configuration-service with keptn/configuration-service:0.9.3-dev-PR-5499.202110051249 and keptn/configuration-service:0.9.3-dev-PR-5499 (Source: configuration-service/)
  • Retagged unchanged image keptn/jmeter-service with keptn/jmeter-service:0.9.3-dev-PR-5499.202110051249 and keptn/jmeter-service:0.9.3-dev-PR-5499 (Source: jmeter-service/)
  • Retagged unchanged image keptn/helm-service with keptn/helm-service:0.9.3-dev-PR-5499.202110051249 and keptn/helm-service:0.9.3-dev-PR-5499 (Source: helm-service/)
  • Retagged unchanged image keptn/bridge2 with keptn/bridge2:0.9.3-dev-PR-5499.202110051249 and keptn/bridge2:0.9.3-dev-PR-5499 (Source: bridge/)
  • Retagged unchanged image keptn/lighthouse-service with keptn/lighthouse-service:0.9.3-dev-PR-5499.202110051249 and keptn/lighthouse-service:0.9.3-dev-PR-5499 (Source: lighthouse-service/)
  • Retagged unchanged image keptn/secret-service with keptn/secret-service:0.9.3-dev-PR-5499.202110051249 and keptn/secret-service:0.9.3-dev-PR-5499 (Source: secret-service/)
  • Retagged unchanged image keptn/remediation-service with keptn/remediation-service:0.9.3-dev-PR-5499.202110051249 and keptn/remediation-service:0.9.3-dev-PR-5499 (Source: remediation-service/)
  • Retagged unchanged image keptn/openshift-route-service with keptn/openshift-route-service:0.9.3-dev-PR-5499.202110051249 and keptn/openshift-route-service:0.9.3-dev-PR-5499 (Source: platform-support/openshift-route-service/)
  • Retagged unchanged image keptn/shipyard-controller with keptn/shipyard-controller:0.9.3-dev-PR-5499.202110051249 and keptn/shipyard-controller:0.9.3-dev-PR-5499 (Source: shipyard-controller/)
  • Retagged unchanged image keptn/statistics-service with keptn/statistics-service:0.9.3-dev-PR-5499.202110051249 and keptn/statistics-service:0.9.3-dev-PR-5499 (Source: statistics-service/)
  • Retagged unchanged image keptn/webhook-service with keptn/webhook-service:0.9.3-dev-PR-5499.202110051249 and keptn/webhook-service:0.9.3-dev-PR-5499 (Source: webhook-service/)
  • Pushed keptn/mongodb-datastore:0.9.3-dev-PR-5499.202110051249 and keptn/mongodb-datastore:0.9.3-dev-PR-5499 (Source: mongodb-datastore/)

RealAnna
RealAnna approved these changes Oct 5, 2021
View reviewed changes
Copy link
Contributor

@RealAnna RealAnna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@warber warber merged commit e944e30 into master Oct 5, 2021
@warber warber deleted the fix/5476/fix-mongodb-datastore-readiness-probe branch October 5, 2021 14:28
bhamail pushed a commit to bhamail/keptn that referenced this pull request Oct 6, 2021
@warber @bhamail
fix(mongodb-datastore): added dedicated get endpoint for readiness pr…
bc846e5 
…obe (keptn#5499)

* added dedicated get endpoint for readiness probe

Signed-off-by: warber <bernd.warmuth@dynatrace.com>

* register new endpoint

Signed-off-by: warber <bernd.warmuth@dynatrace.com>
Signed-off-by: Dan Rollo <danrollo@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bacherfl bacherfl bacherfl approved these changes

@RealAnna RealAnna RealAnna approved these changes

Assignees
No one assigned
Labels
CI:trigger-build-everything Trigger CI Build: Set BUILD_EVERYTHING=TRUE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mongodb-datastore: Panics
3 participants
@warber @bacherfl @RealAnna