Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

fix(approval-service): Fall back to manual strategy when there is no result available (#6012) #6017

Merged
merged 2 commits into from
Nov 18, 2021

Conversation

bacherfl
Copy link
Member

Closes #6012

…result available (#6012)

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Nov 17, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Nov 17, 2021

Codecov Report

Merging #6017 (28b8aff) into master (9c90145) will decrease coverage by 0.98%.
The diff coverage is 91.66%.

@@            Coverage Diff             @@
##           master    #6017      +/-   ##
==========================================
- Coverage   54.26%   53.28%   -0.99%     
==========================================
  Files         399      327      -72     
  Lines       23460    22302    -1158     
  Branches     1204     1058     -146     
==========================================
- Hits        12731    11884     -847     
+ Misses       9816     9523     -293     
+ Partials      913      895      -18     
Impacted Files Coverage Δ
...ce/pkg/handler/approval_triggered_event_handler.go 73.86% <91.66%> (+1.86%) ⬆️
...s/ktb-sequence-view/ktb-sequence-view.component.ts 30.32% <0.00%> (-29.02%) ⬇️
bridge/client/app/_utils/form.utils.ts 63.63% <0.00%> (-27.28%) ⬇️
...ient/app/_interceptors/http-loading-interceptor.ts 81.81% <0.00%> (-18.19%) ⬇️
bridge/shared/models/trace.ts 73.33% <0.00%> (-12.39%) ⬇️
bridge/client/app/_models/trace.ts 55.66% <0.00%> (-6.49%) ⬇️
bridge/client/app/_services/data.service.ts 22.38% <0.00%> (-6.29%) ⬇️
...project-settings/ktb-project-settings.component.ts 71.18% <0.00%> (-5.09%) ⬇️
...uation-details/ktb-evaluation-details.component.ts 17.81% <0.00%> (-4.85%) ⬇️
...lient/app/project-board/project-board.component.ts 68.83% <0.00%> (-4.80%) ⬇️
... and 81 more

@github-actions
Copy link
Contributor

github-actions bot commented Nov 17, 2021

Docker Build Report

  • Pushed keptn/approval-service:0.10.1-dev-PR-6017.202111170741 and keptn/approval-service:0.10.1-dev-PR-6017 (Source: approval-service/)

@bacherfl bacherfl marked this pull request as ready for review November 17, 2021 08:21
@bacherfl bacherfl requested a review from a team as a code owner November 17, 2021 08:21
@bacherfl bacherfl merged commit 9617814 into master Nov 18, 2021
@bacherfl bacherfl deleted the fix/6012/approvals branch November 18, 2021 10:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Approval Service: No .started event being sent when strategy=="manual" && result==""
2 participants