This repository has been archived by the owner on Dec 21, 2023. It is now read-only.
Code and documentation of multiple criteria in SLO objectives is inconsistent #6160
Closed
1 task done
Assignees
Labels
type:bug
Something is not working as intended/documented
Comments
This was referenced Dec 20, 2021
RealAnna
added a commit
that referenced
this issue
Dec 20, 2021
* fix(lighthouse-service): Modified criteria example in SLO (#6106) Signed-off-by: RealAnna <anna.reale@dynatrace.com> * fix(lighthouse-service): review after testing Signed-off-by: RealAnna <anna.reale@dynatrace.com> * fix(lighthouse-service): review after testing Signed-off-by: RealAnna <anna.reale@dynatrace.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The code and documentation about the operator used when applying a set of criteria for an SLO are inconsistent. From the Keptn documentation and the lighthouse-service code, it looks like it is possible to have AND or OR depending on whether you have one criteria element or multiple: the various criteria elements are done with OR but within one it is AND.
But the example in https://github.com/keptn/keptn/tree/master/lighthouse-service#example-slo-file-content contradicts this, saying that elements within a single criteria are combined with OR, and https://github.com/keptn/spec/blob/master/service_level_objective.md doesn't really talk about it.
Environment
keptn version): 0.10.0Affected Component
The text was updated successfully, but these errors were encountered: