Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

Keptn CLI: Improve checks for Helm charts #672

Closed
johannes-b opened this issue Aug 14, 2019 · 1 comment
Closed

Keptn CLI: Improve checks for Helm charts #672

johannes-b opened this issue Aug 14, 2019 · 1 comment
Assignees
@agrimmer
Labels
area:cli type:feature New feature or request that provides value to the stakeholders/end-users
Projects
sprint11 sprint14 sprint15
Milestone
0.5.0

Comments

@johannes-b
Copy link
Member

As a keptn user, I want to specify the service name when onboarding a service (e.g.: carts):
keptn onboard service carts --project=your_project --values=values.yaml
@johannes-b johannes-b added type:feature New feature or request that provides value to the stakeholders/end-users area:cli labels Aug 14, 2019
@johannes-b johannes-b added this to To do in sprint11 via automation Aug 14, 2019
@agrimmer agrimmer moved this from To do to In progress in sprint11 Aug 22, 2019
@agrimmer agrimmer self-assigned this Aug 22, 2019
agrimmer added a commit that referenced this issue Aug 22, 2019
@agrimmer
#672 Helper methods for tar and untar
a9088c0
agrimmer added a commit that referenced this issue Aug 22, 2019
@agrimmer
#672 Validator for helm charts
0e4ffae
agrimmer added a commit that referenced this issue Aug 22, 2019
@agrimmer
#672 Onboard service with helm chart
d090573
@agrimmer agrimmer moved this from In progress to Review in sprint11 Aug 22, 2019
@agrimmer agrimmer moved this from Review to To do in sprint11 Aug 22, 2019
@agrimmer
Copy link
Member

agrimmer commented Aug 22, 2019 •
edited

Partially implemented in branch feature/672/helm-chart-onboarding. Missing:

  • Check whether the helm chart does not contain templates ending with -istio-destinationrule.yaml or -istio-virtualservice.yaml
  • Use types of helm

Furthermore, the helm-service is not ready yet. Hence, do not merge this branch into develop.

agrimmer added a commit that referenced this issue Aug 22, 2019
@agrimmer
#672 Rename keptn type
7140dfe
@agrimmer agrimmer mentioned this issue Aug 22, 2019
Closed
@agrimmer agrimmer changed the title Keptn CLI: add service option to keptn onboard service command (redesign) Keptn CLI: add service option to keptn onboard service command and use Helm chart Aug 22, 2019
agrimmer added a commit that referenced this issue Sep 5, 2019
@agrimmer
Merge pull request #741 from keptn/feature/672/helm-chart-onboarding
57a59c2 
#672 Helm chart onboarding
@johannes-b johannes-b changed the title Keptn CLI: add service option to keptn onboard service command and use Helm chart Keptn CLI: Improve checks for Helm charts Sep 17, 2019
@johannes-b johannes-b added this to To do in sprint13 Sep 17, 2019
@agrimmer agrimmer moved this from To do to In progress in sprint13 Sep 17, 2019
agrimmer added a commit that referenced this issue Sep 17, 2019
@agrimmer
#672 Move logging into pkg
d68e1b0
agrimmer added a commit that referenced this issue Sep 17, 2019
@agrimmer
#672 Improve Helm chart checks
4f0b5e0
agrimmer added a commit that referenced this issue Sep 17, 2019
@agrimmer
Merge pull request #852 from keptn/feature/672/improve-helm-chart-checks
b1a0468 
#672 Improve helm chart checks, move logging
agrimmer added a commit that referenced this issue Sep 17, 2019
@agrimmer
#672 Helm validator tests
3f79bee
@agrimmer agrimmer moved this from In progress to Review in sprint13 Sep 17, 2019
agrimmer added a commit that referenced this issue Sep 17, 2019
@agrimmer
Merge pull request #853 from keptn/feature/672/improve-helm-chart-checks
8f7a7ff 
#672 Helm validator tests
@agrimmer agrimmer moved this from Review to In progress in sprint13 Sep 25, 2019
@johannes-b johannes-b added this to In progress in sprint14 Sep 26, 2019
@johannes-b johannes-b removed this from In progress in sprint13 Sep 26, 2019
@agrimmer agrimmer moved this from In progress to Review in sprint14 Sep 26, 2019
@agrimmer agrimmer added this to the 0.5.0 milestone Sep 26, 2019
@agrimmer agrimmer moved this from Review to In progress in sprint14 Sep 26, 2019
@agrimmer agrimmer moved this from In progress to Review in sprint14 Sep 27, 2019
agrimmer added a commit that referenced this issue Oct 1, 2019
@agrimmer
#672 Remove template checks
1c7dd0a
agrimmer added a commit that referenced this issue Oct 1, 2019
@agrimmer
Merge pull request #908 from keptn/feature/672/remove-template-checks
2cb4948 
#672 Remove template checks
@agrimmer agrimmer closed this as completed Oct 3, 2019
@agrimmer agrimmer moved this from Review to Done in sprint15 Oct 24, 2019
collinjlesko pushed a commit to collinjlesko/keptn that referenced this issue Jan 20, 2020
@agrimmer
keptn#672 Helper methods for tar and untar
01e9deb
collinjlesko pushed a commit to collinjlesko/keptn that referenced this issue Jan 20, 2020
@agrimmer
keptn#672 Validator for helm charts
e73c6fb
collinjlesko pushed a commit to collinjlesko/keptn that referenced this issue Jan 20, 2020
@agrimmer
keptn#672 Onboard service with helm chart
cf2816a
collinjlesko pushed a commit to collinjlesko/keptn that referenced this issue Jan 20, 2020
@agrimmer
keptn#672 Rename keptn type
fbc2f52
collinjlesko pushed a commit to collinjlesko/keptn that referenced this issue Jan 20, 2020
@agrimmer
Merge pull request keptn#741 from keptn/feature/672/helm-chart-onboar…
ed260cb 
…ding

keptn#672 Helm chart onboarding
collinjlesko pushed a commit to collinjlesko/keptn that referenced this issue Jan 20, 2020
@agrimmer
keptn#672 Move logging into pkg
7d26fb9
collinjlesko pushed a commit to collinjlesko/keptn that referenced this issue Jan 20, 2020
@agrimmer
keptn#672 Improve Helm chart checks
bfb77bf
collinjlesko pushed a commit to collinjlesko/keptn that referenced this issue Jan 20, 2020
@agrimmer
Merge pull request keptn#852 from keptn/feature/672/improve-helm-char…
d43e41a 
…t-checks

keptn#672 Improve helm chart checks, move logging
collinjlesko pushed a commit to collinjlesko/keptn that referenced this issue Jan 20, 2020
@agrimmer
keptn#672 Helm validator tests
5d6a39f
collinjlesko pushed a commit to collinjlesko/keptn that referenced this issue Jan 20, 2020
@agrimmer
Merge pull request keptn#853 from keptn/feature/672/improve-helm-char…
4235f82 
…t-checks

keptn#672 Helm validator tests
collinjlesko pushed a commit to collinjlesko/keptn that referenced this issue Jan 20, 2020
@agrimmer
keptn#672 Remove template checks
356dbde
collinjlesko pushed a commit to collinjlesko/keptn that referenced this issue Jan 20, 2020
@agrimmer
Merge pull request keptn#908 from keptn/feature/672/remove-template-c…
b8581e1 
…hecks

keptn#672 Remove template checks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@agrimmer agrimmer

Labels
area:cli type:feature New feature or request that provides value to the stakeholders/end-users
Projects
No open projects
sprint11
  
To do
sprint14
  
Review
sprint15
  
Done
Milestone
0.5.0
Development

No branches or pull requests
2 participants
@johannes-b @agrimmer