Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

fix(webhook-service): Fix retrieval of webhook config #7124

Merged
merged 2 commits into from
Mar 14, 2022

Conversation

bacherfl
Copy link
Member

@bacherfl bacherfl commented Mar 11, 2022

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@bacherfl bacherfl added the CI:trigger-build-everything Trigger CI Build: Set BUILD_EVERYTHING=TRUE label Mar 11, 2022
@bacherfl bacherfl requested a review from a team as a code owner March 11, 2022 09:03
@sonarcloud
Copy link

sonarcloud bot commented Mar 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #7124 (5b03578) into 0.13.x (5053d5c) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           0.13.x    #7124      +/-   ##
==========================================
+ Coverage   57.73%   57.75%   +0.01%     
==========================================
  Files         508      508              
  Lines       29287    29287              
  Branches     1381     1381              
==========================================
+ Hits        16909    16914       +5     
+ Misses      11170    11166       -4     
+ Partials     1208     1207       -1     
Impacted Files Coverage Δ
webhook-service/handler/handler.go 86.20% <100.00%> (+2.95%) ⬆️
distributor/pkg/lib/controlplane/uniformlog.go 71.87% <0.00%> (-4.69%) ⬇️
shipyard-controller/handler/sequencedispatcher.go 69.62% <0.00%> (+1.48%) ⬆️
Flag Coverage Δ
api 71.61% <ø> (ø)
approval-service 71.92% <ø> (ø)
bridge-server 58.30% <ø> (ø)
bridge2 73.13% <ø> (ø)
cli 43.15% <ø> (ø)
configuration-service 8.38% <ø> (ø)
distributor 72.14% <ø> (-0.28%) ⬇️
helm-service 49.23% <ø> (ø)
jmeter-service 13.88% <ø> (ø)
lighthouse-service 74.25% <ø> (ø)
mongodb-datastore 59.86% <ø> (ø)
remediation-service 79.77% <ø> (ø)
resource-service 82.85% <ø> (ø)
secret-service 79.25% <ø> (ø)
shipyard-controller 57.51% <ø> (+0.03%) ⬆️
statistics-service 59.96% <ø> (ø)
webhook-service 79.91% <100.00%> (+1.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@RealAnna RealAnna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, failing integration tests are due to an old version

@RealAnna RealAnna merged commit 07c5025 into 0.13.x Mar 14, 2022
@RealAnna RealAnna deleted the fix/7094/webhook-config branch March 14, 2022 15:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI:trigger-build-everything Trigger CI Build: Set BUILD_EVERYTHING=TRUE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants