Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

fix(shipyard-controller): Make sure sequence queue is free again after aborting a sequence #7126

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

bacherfl
Copy link
Member

Forward-port of #7114
Closes #7116

…r aborting a sequence (#7114)

* test: Added test cases for aborting sequences

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>

* included sequence abortion backport of 0.13

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>

* make sure all task executions for a sequence are deleted when a sequence is cancelled

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>

* make sure all task executions for a sequence are deleted when a sequence is cancelled

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>

* fix integration tests

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>

* increase integration test timeout

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>

* fix integration test

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>

* fix integration test

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>

* fix integration test

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>

(cherry picked from commit 6b0aaac)
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@bacherfl bacherfl added the CI:trigger-build-everything Trigger CI Build: Set BUILD_EVERYTHING=TRUE label Mar 11, 2022
@sonarcloud
Copy link

sonarcloud bot commented Mar 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #7126 (e2a3383) into 0.13.x (5053d5c) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           0.13.x    #7126      +/-   ##
==========================================
- Coverage   57.73%   57.72%   -0.02%     
==========================================
  Files         508      508              
  Lines       29287    29317      +30     
  Branches     1381     1381              
==========================================
+ Hits        16909    16923      +14     
- Misses      11170    11181      +11     
- Partials     1208     1213       +5     
Impacted Files Coverage Δ
shipyard-controller/handler/shipyardcontroller.go 57.03% <20.00%> (-0.59%) ⬇️
...ipyard-controller/db/mongodb_task_sequence_repo.go 65.83% <65.00%> (-0.17%) ⬇️
distributor/pkg/lib/controlplane/uniformlog.go 71.87% <0.00%> (-4.69%) ⬇️
shipyard-controller/handler/sequencedispatcher.go 69.62% <0.00%> (+1.48%) ⬆️
Flag Coverage Δ
api 71.61% <ø> (ø)
approval-service 71.92% <ø> (ø)
bridge-server 58.30% <ø> (ø)
bridge2 73.13% <ø> (ø)
cli 43.15% <ø> (ø)
configuration-service 8.38% <ø> (ø)
distributor 72.14% <ø> (-0.28%) ⬇️
helm-service 49.23% <ø> (ø)
jmeter-service 13.88% <ø> (ø)
lighthouse-service 74.25% <ø> (ø)
mongodb-datastore 59.86% <ø> (ø)
remediation-service 79.77% <ø> (ø)
resource-service 82.85% <ø> (ø)
secret-service 79.25% <ø> (ø)
shipyard-controller 57.47% <50.00%> (-0.01%) ⬇️
statistics-service 59.96% <ø> (ø)
webhook-service 78.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@RealAnna RealAnna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thisthat thisthat merged commit ca6fbf8 into 0.13.x Mar 15, 2022
@thisthat thisthat deleted the fix/7116/abort-sequences-013 branch March 15, 2022 12:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI:trigger-build-everything Trigger CI Build: Set BUILD_EVERYTHING=TRUE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants