Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

fix(bridge): Pretty-print request errors #7652

Merged
merged 1 commit into from
May 5, 2022

Conversation

Kirdock
Copy link
Contributor

@Kirdock Kirdock commented May 4, 2022

Removes unnecessary data from the error log.

Signed-off-by: Klaus Strießnig k.striessnig@gmail.com

Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented May 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented May 4, 2022

Codecov Report

Merging #7652 (9ee1003) into master (ba102d5) will increase coverage by 0.00%.
The diff coverage is 90.90%.

@@           Coverage Diff           @@
##           master    #7652   +/-   ##
=======================================
  Coverage   59.88%   59.88%           
=======================================
  Files         559      560    +1     
  Lines       31944    31946    +2     
  Branches     1601     1601           
=======================================
+ Hits        19130    19132    +2     
  Misses      11502    11502           
  Partials     1312     1312           
Impacted Files Coverage Δ
bridge/server/services/data-service.ts 62.04% <0.00%> (ø)
bridge/server/app.ts 44.44% <100.00%> (-2.19%) ⬇️
bridge/server/utils/print-utils.ts 100.00% <100.00%> (ø)
Flag Coverage Δ
bridge-server 67.15% <90.90%> (+0.04%) ⬆️
bridge2 73.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@renepanzar renepanzar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Kirdock Kirdock merged commit 5b395b9 into master May 5, 2022
@Kirdock Kirdock deleted the fix/pretty-print-request-error branch May 5, 2022 07:17
bacherfl pushed a commit that referenced this pull request May 6, 2022
Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants