This repository has been archived by the owner on Dec 21, 2023. It is now read-only.
fix(webhook-service): Do not respond to anything else than .triggered event on pre execution error #8337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… event on pre execution error Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Codecov Report
@@ Coverage Diff @@
## master #8337 +/- ##
==========================================
+ Coverage 66.13% 66.16% +0.03%
==========================================
Files 606 607 +1
Lines 31726 31749 +23
Branches 1688 1697 +9
==========================================
+ Hits 20983 21008 +25
+ Misses 9443 9441 -2
Partials 1300 1300
Flags with carried forward coverage won't be shown. Click here to find out more. |
bacherfl
added
the
CI:trigger-build-everything
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
|
Kudos, SonarCloud Quality Gate passed!
|
bacherfl
removed
the
CI:trigger-build-everything
warber
approved these changes
Jul 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8334
This fixes a bug due to which the webhook service was responding with a
startedevent if something went wrong with the retrieval of the webhook config (e.g. if the project has. been deleted at the point where the service received the event).