This repository has been archived by the owner on Dec 21, 2023. It is now read-only.
feat: remove webhook migration command from CLI #9463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #9463 +/- ##
==========================================
+ Coverage 70.67% 70.94% +0.27%
==========================================
Files 619 618 -1
Lines 33020 32692 -328
Branches 1643 1643
==========================================
- Hits 23337 23194 -143
+ Misses 8436 8255 -181
+ Partials 1247 1243 -4
Flags with carried forward coverage won't be shown. Click here to find out more. |
RealAnna
approved these changes
Jan 23, 2023
mowies
approved these changes
Jan 23, 2023
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9462
This PR removes the
migrate-webhookscommand from the CLI since the previous webhook config format has not been supported anymore since 0.19.x. This will remove the dependency to the webhook-service from the CLI'sgo.modfile.