Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

#2139 Improve coloring coding for problem event #2230

Merged

Conversation

ermin-muratovic
Copy link
Member

Fixes #2139

@johannes-b johannes-b changed the title Improve coloring coding for problem event #2139 Improve coloring coding for problem event Aug 24, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #2230 into master will increase coverage by 0.04%.
The diff coverage is 30.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2230      +/-   ##
==========================================
+ Coverage   35.53%   35.58%   +0.04%     
==========================================
  Files         150      150              
  Lines        8738     8738              
  Branches      144      146       +2     
==========================================
+ Hits         3105     3109       +4     
+ Misses       5208     5203       -5     
- Partials      425      426       +1     
Flag Coverage Δ
#moduleA 25.55% <30.00%> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...uation-details/ktb-evaluation-details.component.ts 15.21% <ø> (ø)
bridge/client/app/_models/root.ts 0.00% <0.00%> (ø)
bridge/client/app/_models/trace.ts 43.47% <42.85%> (-0.97%) ⬇️
...b-selectable-tile/ktb-selectable-tile.component.ts 60.52% <50.00%> (-1.98%) ⬇️
distributor/cmd/main.go 58.24% <0.00%> (+1.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83a11f2...cbf766c. Read the comment docs.

Copy link
Member

@johannes-b johannes-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@johannes-b
Copy link
Member

Works great!

✔️ A resoled problem turns the root event from red to green:

image

✔️ A failed evaluation leaves the root event red:

image

✔️ A passed evaluation turns the root event from red to green:

image

@johannes-b johannes-b merged commit 39a22ab into master Aug 26, 2020
@johannes-b johannes-b deleted the feature/2139/improve-coloring-coding-for-problem-event branch August 26, 2020 07:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong color-coding in Keptn Bridge for problem.resolved event
3 participants