Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

Enhance JMeter result message #3685

Merged

Conversation

mishraprafful
Copy link
Contributor

@mishraprafful mishraprafful commented Apr 1, 2021

Changes

  • Added Quick DNS lookup check for service Url with a relevant message for failure
  • Added message parameter to sendTestsFinishedEvent method

Related Issue
Closes #3559

Copy link
Member

@johannes-b johannes-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please my comments under consideration.

jmeter-service/main.go Outdated Show resolved Hide resolved
jmeter-service/main.go Outdated Show resolved Hide resolved
jmeter-service/main.go Outdated Show resolved Hide resolved
jmeter-service/main.go Outdated Show resolved Hide resolved
mishraprafful added 7 commits April 5, 2021 14:05
Signed-off-by: mishraprafful <prafful.mishra@volvocars.com>
Signed-off-by: mishraprafful <prafful.mishra@volvocars.com>
Signed-off-by: mishraprafful <prafful.mishra@volvocars.com>
Signed-off-by: mishraprafful <prafful.mishra@volvocars.com>
Signed-off-by: mishraprafful <prafful.mishra@volvocars.com>
Signed-off-by: mishraprafful <prafful.mishra@volvocars.com>
Signed-off-by: mishraprafful <prafful.mishra@volvocars.com>
@mishraprafful mishraprafful force-pushed the feature/3559/better_Jmeter_result branch from 7811079 to 167592b Compare April 5, 2021 12:05
@codecov
Copy link

codecov bot commented Apr 5, 2021

Codecov Report

Merging #3685 (1b1f3f9) into master (2ecfb98) will decrease coverage by 0.72%.
The diff coverage is 0.00%.

❗ Current head 1b1f3f9 differs from pull request most recent head 167592b. Consider uploading reports for the commit 167592b to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3685      +/-   ##
==========================================
- Coverage   42.20%   41.47%   -0.73%     
==========================================
  Files         222      216       -6     
  Lines       11741    11541     -200     
  Branches      291      291              
==========================================
- Hits         4955     4787     -168     
+ Misses       6157     6133      -24     
+ Partials      629      621       -8     
Flag Coverage Δ *Carryforward flag
api 29.89% <ø> (ø) Carriedforward from 069dd0f
approval-service 84.61% <ø> (ø) Carriedforward from 069dd0f
bridge 20.36% <ø> (ø) Carriedforward from 069dd0f
cli 41.58% <ø> (ø) Carriedforward from 069dd0f
configuration-service 19.51% <ø> (ø) Carriedforward from 069dd0f
distributor 54.38% <ø> (ø) Carriedforward from 069dd0f
helm-service 45.70% <ø> (ø) Carriedforward from 069dd0f
jmeter-service 10.92% <0.00%> (-0.27%) ⬇️
lighthouse-service 62.55% <ø> (ø) Carriedforward from 069dd0f
mongodb-datastore 24.53% <ø> (ø) Carriedforward from 069dd0f
openshift-route-service 33.82% <ø> (ø) Carriedforward from 069dd0f
remediation-service 60.41% <ø> (ø) Carriedforward from 069dd0f
secret-service ?
shipyard-controller 55.73% <ø> (ø) Carriedforward from 069dd0f
statistics-service 55.31% <ø> (ø) Carriedforward from 069dd0f

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
jmeter-service/main.go 2.13% <0.00%> (-0.13%) ⬇️
secret-service/pkg/backend/registry.go
secret-service/pkg/backend/secretbackend_k8s.go
secret-service/pkg/handler/common.go
secret-service/pkg/common/utils.go
secret-service/pkg/repository/scopes.go
secret-service/pkg/handler/secrethandler.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ecfb98...167592b. Read the comment docs.

@mishraprafful
Copy link
Contributor Author

@johannes-b Thanks a lot for the comments, I've made the relevant changes.
Please consider this for a re-review. Also, please let me know if the code coverage drop is within permissible limits.

Copy link
Member

@johannes-b johannes-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@johannes-b johannes-b merged commit 78b89c1 into keptn:master Apr 7, 2021
@mishraprafful mishraprafful deleted the feature/3559/better_Jmeter_result branch April 23, 2021 10:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need better JMeter result other than just fail
2 participants