Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

#3668 improved version check #3797

Merged
merged 2 commits into from Apr 21, 2021

Conversation

Kirdock
Copy link
Contributor

@Kirdock Kirdock commented Apr 15, 2021

Closes #3668
Related PR: keptn/keptn.github.io#791
Signed-off-by: Klaus Strießnig k.striessnig@gmail.com

Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>
@codecov
Copy link

codecov bot commented Apr 15, 2021

Codecov Report

Merging #3797 (c8e5e0d) into master (62d02d5) will decrease coverage by 0.65%.
The diff coverage is 35.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3797      +/-   ##
==========================================
- Coverage   44.57%   43.92%   -0.66%     
==========================================
  Files         229      223       -6     
  Lines       12055    11846     -209     
  Branches      307      308       +1     
==========================================
- Hits         5374     5203     -171     
+ Misses       6018     5988      -30     
+ Partials      663      655       -8     
Flag Coverage Δ *Carryforward flag
api 29.89% <ø> (ø) Carriedforward from 62d02d5
approval-service 84.61% <ø> (ø) Carriedforward from 62d02d5
bridge 33.62% <35.29%> (-0.19%) ⬇️
cli 43.87% <ø> (ø) Carriedforward from 62d02d5
configuration-service 19.51% <ø> (ø) Carriedforward from 62d02d5
distributor 54.38% <ø> (ø) Carriedforward from 62d02d5
helm-service 46.06% <ø> (ø) Carriedforward from 62d02d5
jmeter-service 10.92% <ø> (ø) Carriedforward from 62d02d5
lighthouse-service 62.55% <ø> (ø) Carriedforward from 62d02d5
mongodb-datastore 24.34% <ø> (ø) Carriedforward from 62d02d5
openshift-route-service 33.82% <ø> (ø) Carriedforward from 62d02d5
remediation-service 60.41% <ø> (ø) Carriedforward from 62d02d5
secret-service ?
shipyard-controller 55.96% <ø> (ø) Carriedforward from 62d02d5
statistics-service 55.31% <ø> (ø) Carriedforward from 62d02d5

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
bridge/client/app/_services/api.service.ts 13.63% <0.00%> (-0.88%) ⬇️
...idge/client/app/app-header/app-header.component.ts 52.94% <42.85%> (-3.43%) ⬇️
secret-service/pkg/handler/secrethandler.go
secret-service/pkg/handler/common.go
secret-service/pkg/repository/scopes.go
secret-service/pkg/backend/registry.go
secret-service/pkg/backend/secretbackend_k8s.go
secret-service/pkg/common/utils.go
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62d02d5...c8e5e0d. Read the comment docs.

Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>
@github-actions
Copy link
Contributor

The following Docker Images have been built:

  • Pushed keptn/bridge2:0.8.2-dev-PR-3797.202104191443 and keptn/bridge2:0.8.2-dev-PR-3797 (Source: bridge/)

Copy link
Member

@ermin-muratovic ermin-muratovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ermin-muratovic ermin-muratovic merged commit b167666 into master Apr 21, 2021
@ermin-muratovic ermin-muratovic deleted the feature/3668/version-check-improvement branch April 21, 2021 09:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Daily version check was disabled
4 participants