Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

fix(shipyard-controller): Avoid endless loop (#5096) #5124

Merged
merged 1 commit into from Sep 1, 2021

Conversation

bacherfl
Copy link
Member

@bacherfl bacherfl commented Sep 1, 2021

Closes #5096

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@bacherfl bacherfl requested a review from a team as a code owner September 1, 2021 09:27
@bacherfl bacherfl changed the title bug(shipyard-controller): Avoid endless loop (#5096) fix(shipyard-controller): Avoid endless loop (#5096) Sep 1, 2021
@sonarcloud
Copy link

sonarcloud bot commented Sep 1, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Sep 1, 2021

Codecov Report

Merging #5124 (cd84038) into release-0.9.0 (acdbd48) will decrease coverage by 0.48%.
The diff coverage is 70.00%.

❗ Current head cd84038 differs from pull request most recent head 8ce990f. Consider uploading reports for the commit 8ce990f to get more accurate results

@@                Coverage Diff                @@
##           release-0.9.0    #5124      +/-   ##
=================================================
- Coverage          52.26%   51.78%   -0.49%     
=================================================
  Files                299      293       -6     
  Lines              17582    17312     -270     
  Branches             692      692              
=================================================
- Hits                9190     8965     -225     
+ Misses              7531     7494      -37     
+ Partials             861      853       -8     
Impacted Files Coverage Δ
shipyard-controller/handler/sequence_migrator.go 72.72% <70.00%> (+0.16%) ⬆️
secret-service/pkg/backend/registry.go
secret-service/pkg/common/utils.go
secret-service/pkg/repository/scopes.go
secret-service/pkg/handler/common.go
secret-service/pkg/handler/secrethandler.go
secret-service/pkg/backend/secretbackend_k8s.go

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2021

Docker Build Report

  • Pushed keptn/shipyard-controller:0.8.8-dev-PR-5124.202109010927 and keptn/shipyard-controller:0.8.8-dev-PR-5124 (Source: shipyard-controller/)

@laneli laneli merged commit 7521471 into release-0.9.0 Sep 1, 2021
@laneli laneli deleted the bug/5096/sequence-migrator-090 branch September 1, 2021 10:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants