Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

fix: fixed dependency incompatibilities in go-tests (#5078) #5127

Merged
merged 1 commit into from Sep 1, 2021
Merged

fix: fixed dependency incompatibilities in go-tests (#5078) #5127

merged 1 commit into from Sep 1, 2021

Conversation

bacherfl
Copy link
Member

@bacherfl bacherfl commented Sep 1, 2021

Closes #5078

@bacherfl
fix: fixed dependency incompatibilities (#5078)
b9a0085 
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@bacherfl bacherfl requested a review from a team as a code owner September 1, 2021 11:52
@bacherfl bacherfl changed the title fix: fixed dependency incompatibilities (#5078) fix: fixed dependency incompatibilities in go-tests (#5078) Sep 1, 2021
@sonarcloud
Copy link

sonarcloud bot commented Sep 1, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

ermin-muratovic
ermin-muratovic approved these changes Sep 1, 2021
View reviewed changes
Copy link
Member

@ermin-muratovic ermin-muratovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Sep 1, 2021

Codecov Report

Merging #5127 (b9a0085) into master (d2ca280) will decrease coverage by 0.48%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5127      +/-   ##
==========================================
- Coverage   52.24%   51.76%   -0.49%     
==========================================
  Files         299      293       -6     
  Lines       17581    17310     -271     
  Branches      692      692              
==========================================
- Hits         9186     8960     -226     
+ Misses       7533     7496      -37     
+ Partials      862      854       -8
Impacted Files Coverage Δ
secret-service/pkg/repository/scopes.go
secret-service/pkg/handler/secrethandler.go
secret-service/pkg/backend/secretbackend_k8s.go
secret-service/pkg/backend/registry.go
secret-service/pkg/common/utils.go
secret-service/pkg/handler/common.go

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2021 •
edited

Docker Build Report

  • Pushed keptn/shipyard-controller:0.8.8-dev-PR-5127.202109011152 and keptn/shipyard-controller:0.8.8-dev-PR-5127 (Source: shipyard-controller/)

@bacherfl bacherfl merged commit 7fca5de into master Sep 1, 2021
@bacherfl bacherfl deleted the fix/5089/dependency-incompatibilities branch September 1, 2021 12:25
laneli pushed a commit that referenced this pull request Sep 9, 2021
@bacherfl @laneli
fix: fixed dependency incompatibilities (#5078) (#5127)
dc1a006 
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Elisabeth Lang <elisabeth.lang@dynatrace.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ermin-muratovic ermin-muratovic ermin-muratovic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integration tests failed
2 participants
@bacherfl @ermin-muratovic