This repository has been archived by the owner on Dec 21, 2023. It is now read-only.
feat: Add warning for missing upstream during 'keptn create project' #6433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
odubajDT
force-pushed
the
feat/6306/add-missing-upstream-warning
branch
from
7ef6d14
to
d1f1815
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #6433 +/- ##
==========================================
- Coverage 57.65% 54.28% -3.38%
==========================================
Files 466 336 -130
Lines 26560 22613 -3947
Branches 1810 1167 -643
==========================================
- Hits 15314 12275 -3039
+ Misses 10219 9376 -843
+ Partials 1027 962 -65
|
odubajDT
changed the title
odubajDT
changed the title
| @@ -25,7 +26,7 @@ type createProjectCmdParams struct { | |||
| var createProjectParams *createProjectCmdParams | |||
|
|
|||
| const gitErrMsg = `Please specify a 'git-user', 'git-token', and 'git-remote-url' as flags for configuring a Git upstream repository` | |||
| const gitMissingUpstream = `WARNING: Creating a project without Git upstream repository is not recommended. | |||
| const gitMissingUpstream = `WARNING: Creating a project without Git upstream repository is not recommended and will not be supported in the future anymore. | |||
There was a problem hiding this comment.
I think we should be a bit more specific here, e.g., stating which version we plan to deprecate this support.
Though you have implemented it according to #6306, so I'll approve this.
There was a problem hiding this comment.
I can add a specific version there, it is not a problem, but do we already know in which version we want to deprecate the support ?
christian-kreuzberger-dtx
approved these changes
Dec 28, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: odubajDT ondrej.dubaj@dynatrace.com
This PR
Related Issues
Fixes #6306