Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

fix(bridge): Show error when having problems parsing shipyard.yaml (#6592) #6606

Merged
merged 26 commits into from
Jan 28, 2022

Conversation

ermin-muratovic
Copy link
Member

This PR

  • fixes the webhook configuration screen when having issues parsing shipyard.yaml and shows a proper error message

Related Issues

Fixes #6592

image

@codecov
Copy link

codecov bot commented Jan 17, 2022

Codecov Report

Merging #6606 (e33a1bc) into master (1a657c8) will increase coverage by 0.26%.
The diff coverage is 26.66%.

@@            Coverage Diff             @@
##           master    #6606      +/-   ##
==========================================
+ Coverage   57.07%   57.33%   +0.26%     
==========================================
  Files         499      504       +5     
  Lines       28550    28620      +70     
  Branches     1340     1356      +16     
==========================================
+ Hits        16295    16410     +115     
+ Misses      11047    11009      -38     
+ Partials     1208     1201       -7     
Impacted Files Coverage Δ
...ion/ktb-modify-uniform-subscription.component.html 100.00% <ø> (ø)
bridge/server/services/data-service.ts 60.06% <0.00%> (+0.35%) ⬆️
...ption/ktb-modify-uniform-subscription.component.ts 94.80% <42.85%> (-3.85%) ⬇️
.../server/fixtures/shipyard-invalid-response.mock.ts 100.00% <100.00%> (ø)
...te-secret-form/ktb-create-secret-form.component.ts 97.77% <0.00%> (-2.23%) ⬇️
bridge/server/app.ts 47.77% <0.00%> (-0.54%) ⬇️
bridge/client/app/app.module.ts 100.00% <0.00%> (ø)
bridge/server/.jest/test.utils.ts 100.00% <0.00%> (ø)
bridge/client/app/_models/notification.ts 100.00% <0.00%> (ø)
... and 14 more
Flag Coverage Δ
bridge-server 59.27% <12.50%> (+3.76%) ⬆️
bridge2 74.13% <42.85%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@Kirdock Kirdock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add some UI tests for this error?

  • Test if the reload button exists on error
  • Test if the reload button works (maybe check it in a way that before the reload, the response is adjusted to a valid one)

Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>
Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>
Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>
Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>
Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>
Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>
Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>
Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>
Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>
Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>
Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>
Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>
Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>
Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>
Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>
Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>
Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>
@ermin-muratovic ermin-muratovic force-pushed the bug/6592/show-error-parsing-shipyard-yaml branch from be49181 to cab8d1f Compare January 27, 2022 08:36
Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>
Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>
Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>
Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>
Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>
Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>
Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>
Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>
Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Jan 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ermin-muratovic ermin-muratovic merged commit 0ceb54d into master Jan 28, 2022
@ermin-muratovic ermin-muratovic deleted the bug/6592/show-error-parsing-shipyard-yaml branch January 28, 2022 11:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error message: Can we improve error message on API errors due to shipyard parsing
3 participants