This repository has been archived by the owner on Dec 21, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 249
fix(bridge): Show error when having problems parsing shipyard.yaml (#6592) #6606
Merged
ermin-muratovic
merged 26 commits into
master
from
bug/6592/show-error-parsing-shipyard-yaml
Jan 28, 2022
Merged
fix(bridge): Show error when having problems parsing shipyard.yaml (#6592) #6606
ermin-muratovic
merged 26 commits into
master
from
bug/6592/show-error-parsing-shipyard-yaml
Jan 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6606 +/- ##
==========================================
+ Coverage 57.07% 57.33% +0.26%
==========================================
Files 499 504 +5
Lines 28550 28620 +70
Branches 1340 1356 +16
==========================================
+ Hits 16295 16410 +115
+ Misses 11047 11009 -38
+ Partials 1208 1201 -7
Flags with carried forward coverage won't be shown. Click here to find out more. |
Kirdock
suggested changes
Jan 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add some UI tests for this error?
- Test if the reload button exists on error
- Test if the reload button works (maybe check it in a way that before the reload, the response is adjusted to a valid one)
...app/_components/ktb-modify-uniform-subscription/ktb-modify-uniform-subscription.component.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>
Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>
Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>
Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>
Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>
Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>
Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>
Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>
Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>
Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>
Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>
Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>
Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>
Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>
Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>
Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>
Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>
ermin-muratovic
force-pushed
the
bug/6592/show-error-parsing-shipyard-yaml
branch
from
January 27, 2022 08:36
be49181
to
cab8d1f
Compare
Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>
Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>
Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>
Kirdock
previously requested changes
Jan 27, 2022
Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>
Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>
Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>
Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>
Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>
Signed-off-by: ermin.muratovic <ermin.muratovic@gmail.com>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
laneli
approved these changes
Jan 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Related Issues
Fixes #6592