Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

fix(shipyard-controller): Do not overwrite subscriptions #7057

Closed
wants to merge 44 commits into from
Closed

fix(shipyard-controller): Do not overwrite subscriptions #7057

wants to merge 44 commits into from

Conversation

bacherfl
Copy link
Member

@bacherfl bacherfl commented Mar 3, 2022

Closes #7047

bacherfl and others added 30 commits March 3, 2022 09:04
@bacherfl
fix(shipyard-controller): Do not overwrite existing subscriptions in …
3d557d0 
…case of version update

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@bacherfl
added assertion to check if subscriptions are still there after versi…
b57f8a7 
…on upgrade

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@bacherfl
added assertion to check if subscriptions are still there after versi…
0c301b8 
…on upgrade

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@bacherfl
fixed typo
ce7ce50 
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@bacherfl
fixed sonar warnings
b3a5944 
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@bacherfl
added comment
8596714 
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@bacherfl
pr review
2e06a39 
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@bacherfl
added unit test for repo implementation
a41fa3d 
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@mowies
ci: Add pipeline to nightly check docker image digests (#6598)
02a2f79 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
ci: Minor pipeline improvements (#6613)
bdf50a9 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
ci: Only push docker images if not from a forked repo (#6618)
41f4e08 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies @thisthat
ci: Fix digest checker pipeline (#6619)
4470f0f 
Co-authored-by: Giovanni Liva <giovanni.liva@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
ci: Fix CI pipeline not pushing master images to registry (#6634)
4f30919 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
feat: Release helm charts on GitHub pages (#6559)
b4367a6 
BREAKING CHANGES: The Keptn Helm charts are now served from the [keptn/helm-charts](https://github.com/keptn/helm-charts) repository through GitHub pages. They are accessible by using https://charts.keptn.sh as a helm chart repository.

Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
ci: Remove unneeded pipelines and config files (#6642)
94de548 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
ci: Fix master builds not pushing docker images (#6643)
7216d49 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
ci: Fix master builds not pushing docker images (#6659)
38bd3ca 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
ci: Fix intergation tests taking master artifacts from bot commits (#…
941b81d 
…6670)

Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies @thisthat
test: Integration Tests on static GKE clusters (#6632)
f435992 
Co-authored-by: Giovanni Liva <giovanni.liva@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
chore: Add k8s resource stats to release notes (#6718)
940bc5a 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
ci: Fix dev helm charts not having a unique image name (#6816)
066b099 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
ci: Disable manual triggers of the CI pipeline (#6819)
3dd0f26 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
ci: Always use datetimed version for integration tests (#6820)
d28942c 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
ci: Ensure that build matrix runs as far as possible (#6875)
5d3b7a0 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
ci: Only upload dev helm chart for non-fork PRs (#6763)
90f13fb 
(cherry picked from commit 134d487)
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
ci: Push dev images to dev dockerhub registry, adjust helm charts (#6857
5cba7a1 
)

(cherry picked from commit 59a7762)
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
chore: Removed makefile and all usages of it (#6804)
9911a24 
(cherry picked from commit e55355f)
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
ci: Fix cleanup in integration tests to also include clusterroles and…
7ea0264 
… clusterrolebindings (#6931)

(cherry picked from commit 3dd71e5)
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
ci: Fix release pipeline not uploading helm charts correctly (#6944)
411a89a 
(cherry picked from commit 0609c7d)
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
ci: Fix integration test pipeline not starting if there were 404ing C…
7b7295c 
…I pipeline runs in the source branch (#6966)

(cherry picked from commit 23c4c37)
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
mowies and others added 12 commits March 3, 2022 13:32
@mowies
ci: Fix resource cleanup in integration tests when resource arrays ar…
ebc9879 
…e empty (#6971)

(cherry picked from commit 2abb21c)
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@bacherfl
added comment
916e0b4 
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@bacherfl
fix(shipyard-controller): Do not overwrite existing subscriptions in …
1e8ad14 
…case of version update

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@bacherfl
added assertion to check if subscriptions are still there after versi…
584daaf 
…on upgrade

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@bacherfl
added assertion to check if subscriptions are still there after versi…
03ca22a 
…on upgrade

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@bacherfl
fixed typo
c3cb287 
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@bacherfl
fixed sonar warnings
e47b0b8 
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@bacherfl
added comment
138d831 
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@bacherfl
pr review
7bf6c86 
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@bacherfl
added unit test for repo implementation
bb69b39 
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@bacherfl
added comment
8af5c17 
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@bacherfl
Merge branch 'fix/uniform-version-update' of https://github.com/keptn…
6104ac1 
…/keptn into fix/uniform-version-update
@bacherfl bacherfl added the CI:trigger-build-everything Trigger CI Build: Set BUILD_EVERYTHING=TRUE label Mar 3, 2022
@bacherfl
Trigger CI
9296a3a 
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@codecov
Copy link

codecov bot commented Mar 3, 2022 •
edited

Codecov Report

Merging #7057 (38980fe) into 0.12.x (9ea7630) will increase coverage by 0.04%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           0.12.x    #7057      +/-   ##
==========================================
+ Coverage   57.40%   57.45%   +0.04%     
==========================================
  Files         486      486              
  Lines       27796    27838      +42     
  Branches     1295     1295              
==========================================
+ Hits        15957    15994      +37     
- Misses      10654    10658       +4     
- Partials     1185     1186       +1
Impacted Files Coverage Δ
shipyard-controller/db/mongodb_uniform_repo.go 66.35% <59.37%> (-0.54%) ⬇️
...rd-controller/handler/uniformintegrationhandler.go 40.29% <80.00%> (+0.29%) ⬆️
cli/cmd/install.go 45.72% <100.00%> (+1.02%) ⬆️
cli/cmd/install_upgrade_params.go 68.00% <100.00%> (+19.85%) ⬆️
cli/cmd/upgrade.go 31.47% <100.00%> (+1.39%) ⬆️
distributor/pkg/lib/controlplane/uniformlog.go 76.56% <0.00%> (+4.68%) ⬆️
Flag Coverage Δ
api 67.62% <ø> (ø)
approval-service 71.92% <ø> (ø)
bridge-server 48.71% <ø> (ø)
bridge2 74.56% <ø> (ø)
cli 44.12% <100.00%> (+0.22%) ⬆️
configuration-service 8.38% <ø> (ø)
distributor 66.92% <ø> (+0.32%) ⬆️
helm-service 49.04% <ø> (ø)
jmeter-service 13.40% <ø> (ø)
lighthouse-service 74.40% <ø> (ø)
mongodb-datastore 61.24% <ø> (ø)
remediation-service 78.82% <ø> (ø)
resource-service 83.44% <ø> (ø)
secret-service 79.25% <ø> (ø)
shipyard-controller 57.31% <65.95%> (+<0.01%) ⬆️
statistics-service 59.96% <ø> (ø)
webhook-service 78.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@bacherfl
fix error in test_utils
38980fe 
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Mar 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bacherfl bacherfl closed this Mar 3, 2022
@bacherfl bacherfl deleted the fix/7047/uniform-subscriptions branch March 3, 2022 14:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mowies mowies Awaiting requested review from mowies mowies will be requested when the pull request is marked ready for review mowies is a code owner

@christian-kreuzberger-dtx christian-kreuzberger-dtx Awaiting requested review from christian-kreuzberger-dtx christian-kreuzberger-dtx will be requested when the pull request is marked ready for review christian-kreuzberger-dtx is a code owner

@johannes-b johannes-b Awaiting requested review from johannes-b johannes-b will be requested when the pull request is marked ready for review johannes-b is a code owner

@warber warber Awaiting requested review from warber warber will be requested when the pull request is marked ready for review warber is a code owner

@ermin-muratovic ermin-muratovic Awaiting requested review from ermin-muratovic ermin-muratovic will be requested when the pull request is marked ready for review ermin-muratovic is a code owner

@laneli laneli Awaiting requested review from laneli laneli will be requested when the pull request is marked ready for review laneli is a code owner

@Kirdock Kirdock Awaiting requested review from Kirdock Kirdock will be requested when the pull request is marked ready for review Kirdock is a code owner

Assignees
No one assigned
Labels
CI:trigger-build-everything Trigger CI Build: Set BUILD_EVERYTHING=TRUE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bacherfl @mowies