Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

chore(bridge): Enable D3 charts by default #8644

Merged
merged 1 commit into from Aug 12, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Expand Up @@ -36,7 +36,7 @@ describe('AppHeaderComponent', () => {
authType: '',
cliDownloadLink: '',
enableVersionCheckFeature: false,
featureFlags: { D3_ENABLED: false },
featureFlags: { D3_ENABLED: true },
showApiToken: false,
},
};
Expand Down
@@ -1,7 +1,7 @@
import { IClientFeatureFlags } from '../../../../../shared/interfaces/feature-flags';

const featureFlags: IClientFeatureFlags = {
D3_ENABLED: false,
D3_ENABLED: true,
};

const bridgeInfo = {
Expand Down
Expand Up @@ -29,7 +29,7 @@ describe('FeatureFlagsService', () => {
dataService.loadKeptnInfo();
const flags = await firstValueFrom(service.featureFlags$);
expect(flags).toEqual({
D3_ENABLED: false,
D3_ENABLED: true,
});
});
});
2 changes: 1 addition & 1 deletion bridge/cypress/fixtures/bridgeInfo.mock.json
Expand Up @@ -9,6 +9,6 @@
"authType": "OAUTH",
"user": "claus.keptn-dev@ruxitlabs.com",
"featureFlags": {
"D3_ENABLED": false
"D3_ENABLED": true
}
}
2 changes: 1 addition & 1 deletion bridge/cypress/fixtures/bridgeInfoAuthMsg.mock.json
Expand Up @@ -10,6 +10,6 @@
"user": "claus.keptn-dev@ruxitlabs.com",
"authMsg": "Hello handsome",
"featureFlags": {
"D3_ENABLED": false
"D3_ENABLED": true
}
}
2 changes: 1 addition & 1 deletion bridge/cypress/integration/project-create.spec.ts
Expand Up @@ -328,7 +328,7 @@ describe('Automatic provisioning message', () => {
authType: 'OAUTH',
user: 'claus.keptn-dev@ruxitlabs.com',
featureFlags: {
D3_ENABLED: false,
D3_ENABLED: true,
},
};

Expand Down
4 changes: 2 additions & 2 deletions bridge/cypress/support/pageobjects/ServicesPage.ts
Expand Up @@ -301,7 +301,7 @@ class ServicesPage {
}

clickViewServiceDetails(): this {
cy.get('.highcharts-plot-background').should('be.visible');
cy.get('ktb-heatmap .heatmap-container').should('be.visible');
cy.contains('View service details').click();
return this;
}
Expand All @@ -318,7 +318,7 @@ class ServicesPage {

verifyCurrentOpenServiceNameEvaluationPanel(serviceName: string): this {
cy.get('div.service-title > span').should('have.text', serviceName);
cy.get('.highcharts-plot-background').should('be.visible');
cy.get('ktb-heatmap .heatmap-container').should('be.visible');
return this;
}

Expand Down
2 changes: 1 addition & 1 deletion bridge/server/feature-flags.ts
@@ -1,7 +1,7 @@
import { IClientFeatureFlags, IServerFeatureFlags } from '../shared/interfaces/feature-flags';

export class ClientFeatureFlags implements IClientFeatureFlags {
D3_ENABLED = false;
D3_ENABLED = true;
}

export class ServerFeatureFlags implements IServerFeatureFlags {
Expand Down
2 changes: 1 addition & 1 deletion bridge/server/test/bridge-info.spec.ts
Expand Up @@ -41,7 +41,7 @@ describe('Test /bridgeInfo', () => {
enableVersionCheckFeature: true,
showApiToken: true,
featureFlags: {
D3_ENABLED: false,
D3_ENABLED: true,
},
authType: 'NONE',
automaticProvisioningMsg: provMsg.trim(),
Expand Down
2 changes: 1 addition & 1 deletion installer/manifests/keptn/values.yaml
Expand Up @@ -232,7 +232,7 @@ bridge:
mongoConnectionString: ""
authMsg: ""
d3:
enabled: false
enabled: true
nodeSelector: {}
sidecars: []
extraVolumeMounts: []
Expand Down