This repository has been archived by the owner on Dec 21, 2023. It is now read-only.
fix(resource-service): Use go-git master version #9159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #9159 +/- ##
==========================================
- Coverage 70.72% 70.71% -0.01%
==========================================
Files 619 619
Lines 32907 32911 +4
Branches 1647 1647
==========================================
Hits 23274 23274
- Misses 8387 8391 +4
Partials 1246 1246
Flags with carried forward coverage won't be shown. Click here to find out more. |
thisthat
reviewed
Dec 6, 2022
resource-service/go.mod
Outdated
| @@ -6,7 +6,7 @@ require ( | |||
| github.com/gin-gonic/gin v1.8.1 | |||
| github.com/go-git/go-billy/v5 v5.3.1 | |||
| github.com/go-git/go-git-fixtures/v4 v4.3.1 | |||
| github.com/go-git/go-git/v5 v5.4.3-0.20220529141257-bc1f419cebcf // the latest release of this library (5.4.2) has been made over a year ago, but the project is still actively maintained. Using this specific version for now since this includes a fix for the "reference delta not found error" encountered with CodeCommit repos | |||
| github.com/go-git/go-git/v5 v5.4.3-0.20221107161654-452df976faca // the latest release of this library (5.4.2) has been made over a year ago, but the project is still actively maintained. Using this specific version for now since this includes a fix for the "reference delta not found error" encountered with CodeCommit repos | |||
There was a problem hiding this comment.
They release 5.5.0 few days ago https://github.com/go-git/go-git/releases/tag/v5.5.0
There was a problem hiding this comment.
thanks, just updated to this version
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
# Conflicts: # resource-service/go.mod # resource-service/go.sum
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
|
Kudos, SonarCloud Quality Gate passed!
|
odubajDT
approved these changes
Dec 6, 2022
Merged
bacherfl
added a commit
that referenced
this pull request
Dec 7, 2022
This reverts commit 3488c51. Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
bacherfl
added a commit
that referenced
this pull request
Dec 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.