-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add optional field in secretKeyRef #1590
Conversation
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
3f21365
to
b5dec53
Compare
@RealAnna need the PR review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add some description below for the field
added check it |
i don't see anything 😅 |
Ohh sorry my push was not initiated i was my mistake 😁 |
e595880
to
26a819e
Compare
@mowies check it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple little comments but otherwise it looks good
18dff12
to
7f01694
Compare
@StackScribe resolved all issues you can check it now |
55e76c9
to
e8e9c8f
Compare
…st to 36d0c23 (keptn#1511) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Nitishupkr <nitishupkr@gmail.com>
Signed-off-by: Nitishupkr <nitishupkr@gmail.com>
Signed-off-by: Nitishupkr <nitishupkr@gmail.com>
Signed-off-by: Nitishupkr <nitishupkr@gmail.com>
Signed-off-by: Nitishupkr <nitishupkr@gmail.com>
Co-authored-by: Giovanni Liva <giovanni.liva@dynatrace.com> Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com> Signed-off-by: Nitishupkr <nitishupkr@gmail.com>
Signed-off-by: Nitishupkr <nitishupkr@gmail.com>
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com> Signed-off-by: Rakshit Gondwal <98955085+rakshitgondwal@users.noreply.github.com> Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com> Signed-off-by: Nitishupkr <nitishupkr@gmail.com>
@mowies done |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@mowies @StackScribe check this PR for merging |
@StackScribe your approval is needed to merge the PR |
Fixes: #1575