Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add optional field in secretKeyRef #1590

Merged
merged 9 commits into from
Jul 3, 2023
Merged

docs: add optional field in secretKeyRef #1590

merged 9 commits into from
Jul 3, 2023

Conversation

Nitishupkr
Copy link
Contributor

@Nitishupkr Nitishupkr commented Jun 20, 2023 •
edited by mowies
Loading

Fixes: #1575

apiVersion: metrics.keptn.sh/v1alpha3
kind: KeptnMetricsProvider
metadata:
  name: <data-source-instance-name>
  namespace: <namespace>
spec:
  type: prometheus | dynatrace | dql | datadog
  targetServer: "<data-source-url>"
  secretKeyRef:
    name: <secret-name>
    key: <secret-key-that-holds-token>
    optional: true

@Nitishupkr Nitishupkr requested review from a team as code owners June 20, 2023 14:08
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jun 20, 2023
@netlify
Copy link

netlify bot commented Jun 20, 2023 •
edited
Loading

✅ Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 8db98af
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/6494848e88b5e600084815d3
😎 Deploy Preview https://deploy-preview-1590--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Nitishupkr
Copy link
Contributor Author

@RealAnna need the PR review

mowies
mowies requested changes Jun 21, 2023
View reviewed changes
Copy link
Member

@mowies mowies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add some description below for the field

@Nitishupkr
Copy link
Contributor Author

Please also add some description below for the field

added check it

@mowies
Copy link
Member

mowies commented Jun 21, 2023

i don't see anything 😅

@Nitishupkr
Copy link
Contributor Author

Ohh sorry my push was not initiated i was my mistake 😁

@mowies mowies changed the title docs: added the optional property in secretKeyRef field docs: add optional field in secretKeyRef Jun 21, 2023
@Nitishupkr
Copy link
Contributor Author

@mowies check it

StackScribe
StackScribe reviewed Jun 22, 2023
View reviewed changes
Copy link
Contributor

@StackScribe StackScribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple little comments but otherwise it looks good

@Nitishupkr
Copy link
Contributor Author

@StackScribe resolved all issues you can check it now

renovate bot and others added 4 commits June 22, 2023 12:25
@renovate @Nitishupkr
deps: update github.com/keptn/lifecycle-toolkit/metrics-operator dige…
a8606dc 
…st to 36d0c23 (keptn#1511)

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Nitishupkr <nitishupkr@gmail.com>
@Nitishupkr
Update metricsprovider.md
c59eb09 
Signed-off-by: Nitishupkr <nitishupkr@gmail.com>
@Nitishupkr
Update metricsprovider.md
e49db73 
Signed-off-by: Nitishupkr <nitishupkr@gmail.com>
@Nitishupkr
Update metricsprovider.md
5fa7a54 
Signed-off-by: Nitishupkr <nitishupkr@gmail.com>
Nitishupkr and others added 4 commits June 22, 2023 12:25
@Nitishupkr
Update metricsprovider.md
d9d914b 
Signed-off-by: Nitishupkr <nitishupkr@gmail.com>
@StackScribe @thisthat
@bacherfl @Nitishupkr
docs: add content to implementing/otel page (keptn#1492)
3349605 
Co-authored-by: Giovanni Liva <giovanni.liva@dynatrace.com>
Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Nitishupkr <nitishupkr@gmail.com>
@keptn-bot @Nitishupkr
chore: release 0.8.0 (keptn#1358)
8d710e3 
Signed-off-by: Nitishupkr <nitishupkr@gmail.com>
@rakshitgondwal @bacherfl @Nitishupkr
feat: add support for timeframe in KeptnMetric (keptn#1471)
e8e9c8f 
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
Signed-off-by: Rakshit Gondwal <98955085+rakshitgondwal@users.noreply.github.com>
Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Nitishupkr <nitishupkr@gmail.com>
@Nitishupkr
Copy link
Contributor Author

@mowies done

@sonarcloud
Copy link

sonarcloud bot commented Jun 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Nitishupkr
Copy link
Contributor Author

@mowies @StackScribe check this PR for merging

@Nitishupkr
Copy link
Contributor Author

@StackScribe your approval is needed to merge the PR

@StackScribe StackScribe merged commit d0d5bcb into keptn:main Jul 3, 2023
17 checks passed
@keptn-bot keptn-bot mentioned this pull request Jul 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StackScribe StackScribe StackScribe approved these changes

@mowies mowies mowies approved these changes

Assignees

@Nitishupkr Nitishupkr

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

secretKeyRef field is missing the optional property
5 participants
@Nitishupkr @mowies @StackScribe @keptn-bot @rakshitgondwal