Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated fields in KeptnTaskDefinition type and bump the API #3104

Closed
6 tasks done
RealAnna opened this issue Feb 22, 2024 · 3 comments · Fixed by #3345
Closed
6 tasks done

Remove deprecated fields in KeptnTaskDefinition type and bump the API #3104

RealAnna opened this issue Feb 22, 2024 · 3 comments · Fixed by #3345
Assignees
@odubajDT
Labels
chore Maintenance maintenance
Milestone
2.0.0

Comments

@RealAnna
Copy link
Contributor

RealAnna commented Feb 22, 2024 •
edited by odubajDT

The function field in the KeptnTaskDefinition CRD is deprecated, before we release the stable version it should be removed.

Acceptance criteria

  • field removed from here
  • KeptnTaskDefinition CRD regenerated and copied in helm chart
  • CRD docs regenerated
  • API version bumped WITHOUT moving the hub version
  • all yaml files in docs, tests, examples and sample files do not use function but either deno or python
  • check for any other code occurrences that make use of the function field
@RealAnna RealAnna added status: ready-for-refinement Issue is relevant for the next backlog refinment chore Maintenance maintenance labels Feb 22, 2024
@RealAnna RealAnna added this to the 2.0.0 milestone Feb 22, 2024
@mowies mowies changed the title Remove deprecated fields in KeptnTaskDefinition type and bump the api Remove deprecated fields in KeptnTaskDefinition type and bump the API Feb 28, 2024
@mowies mowies removed the status: ready-for-refinement Issue is relevant for the next backlog refinment label Feb 28, 2024
@AryanBakliwal
Copy link
Contributor

Hi @RealAnna, I'm interested in working on this issue. Do you have any suggestions on how I can get started? I appreciate any guidance you can provide!

@odubajDT odubajDT assigned odubajDT and AryanBakliwal and unassigned odubajDT Mar 6, 2024
@AryanBakliwal AryanBakliwal mentioned this issue Mar 13, 2024
Closed
13 tasks
@odubajDT
Copy link
Contributor

odubajDT commented Mar 25, 2024 •
edited

Hi @AryanBakliwal we are sorry but since we are under time pressure regarding the upcoming stable release, we need to tackle this issue ASAP. Therefore we need to unassign you and handle it in the next days. Thank you very much for your work and please feel free to grab some other issue from our backlog!

@odubajDT odubajDT assigned odubajDT and unassigned AryanBakliwal Mar 25, 2024
@AryanBakliwal
Copy link
Contributor

No problem at all. I completely understand the urgency of the situation and am sorry I couldn't complete it in time.

@odubajDT odubajDT mentioned this issue Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@odubajDT odubajDT

Labels
chore Maintenance maintenance
Projects
Keptn Lifecycle Toolkit
Archived in project
Milestone
2.0.0
4 participants
@mowies @RealAnna @odubajDT @AryanBakliwal