chore(lifecycle-operator): remove deprecated fields in KeptnTaskDefinition

[odubajDT]

Fixes: #3104

Depends on: #3344

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.03%. Comparing base (1d851c5) to head (13e31cf).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3345      +/-   ##
==========================================
- Coverage   88.05%   88.03%   -0.02%     
==========================================
  Files         176      176              
  Lines        9608     9604       -4     
==========================================
- Hits         8460     8455       -5     
- Misses        854      856       +2     
+ Partials      294      293       -1     

Files	Coverage Δ
...tor/apis/lifecycle/v1/keptntaskdefinition_types.go	80.00% <ø> (ø)
...s/lifecycle/v1beta1/keptntaskdefinition_webhook.go	91.66% <100.00%> (-0.34%)	⬇️
...rator/controllers/common/taskdefinition/handler.go	100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

Flag	Coverage Δ
certificate-operator	69.23% <ø> (ø)
component-tests	58.77% <ø> (+0.73%)	⬆️
lifecycle-operator	88.08% <100.00%> (-0.01%)	⬇️
metrics-operator	88.18% <ø> (-0.14%)	⬇️
scheduler	34.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[StackScribe]

Did you confirm that https://keptn.sh/stable/docs/reference/crd-reference/taskdefinition/#differences-between-versions is still accurate? It looks like we didn't tell them that function still actually worked in place of deno so maybe we don't need to say that function is shut down in v2.0?

[odubajDT]

Did you confirm that https://keptn.sh/stable/docs/reference/crd-reference/taskdefinition/#differences-between-versions is still accurate? It looks like we didn't tell them that function still actually worked in place of deno so maybe we don't need to say that function is shut down in v2.0?

Good point, looking at the page it states that function is deprecated already in 0.8.0 and will be dropped in future releases. I would say this is good enough here.