-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update DOCKER CMD on docs/Makefile #1745
Conversation
Signed-off-by: Viktorius Suwandi <viktorius.tori@gmail.com>
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
LGTM! Thanks! Closes #1744 |
Unfortunately it seems I was wrong with my suggested fix. The https://github.com/keptn/lifecycle-toolkit/actions/runs/5606326111/jobs/10257542019?pr=1745 |
Hi agardnerIT, |
Due to the issue identified above and the fact that making the change breaks other compatibility (ie. when In other words, When this new task is introduced, the lifecycle-toolkit/docs/README.md Line 14 in 92730ad
Perhaps also, add a note to Sorry for the extra work, but I just don't see another way to achieve this without breaking other things. |
Signed-off-by: Viktorius Suwandi <viktorius.tori@gmail.com>
Signed-off-by: Viktorius Suwandi <viktorius.tori@gmail.com>
Thanks for your explanation @agardnerIT, Actually I don't know how to apply your idea, but this is what I have tried to do :
Please let me know anything need else to do or improve. Appreciate your guidance ! |
i would not suggest to duplicate this file. It creates confusion, and does not make it logical on why to use it or not. eg. this can be determined within the makefile (eg. https://stackoverflow.com/a/4251643/3708208) and we can set a variable based on this definition. Such an approach would make it way clearer to the users, und why there is a difference, and in the end, the end user does not want to ensure a proper file or not. |
what @aepfli said :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@viktoriussuwandi pls check the comment here: #1745 (comment)
Signed-off-by: Viktorius Suwandi <viktorius.tori@gmail.com>
Signed-off-by: Viktorius Suwandi <viktorius.tori@gmail.com>
Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> Signed-off-by: Viktorius Suwandi <viktorius.tori@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one small change, other than that, LGTM
Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> Signed-off-by: Viktorius Suwandi <viktorius.tori@gmail.com>
no problem @mowies, Thanks for your suggestion! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Kudos, SonarCloud Quality Gate passed! |
That's an awesome solution. Definitely learned something here! |
Thanks for this opportunity @ALL |
Nice Solution! well done! |
Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> Signed-off-by: Griffin <prakritimandal611@gmail.com>
Fixes #1744
Hi agardnerIT,
just trying to fix issue on file lifecycle-toolkit/docs/Makefile, please check it out