Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lifecycle-operator): rename CONTEXT to KEPTN_CONTEXT in task runtimes #2521

Merged
merged 5 commits into from
Nov 21, 2023

Conversation

bacherfl
Copy link
Member

@bacherfl bacherfl commented Nov 17, 2023

Closes #2491

BREAKING CHANGE: The environment variable giving deno and python runtime access to context information has been renamed from CONTEXT to KEPTN_CONTEXT

…ntimes

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@github-actions github-actions bot added documentation Improvements or additions to documentation lifecycle-operator labels Nov 17, 2023
Copy link

netlify bot commented Nov 17, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 61d112c
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/655b7539f5779d000875d73b
😎 Deploy Preview https://deploy-preview-2521--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Merging #2521 (75b1db0) into main (540ca90) will increase coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 91.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2521      +/-   ##
==========================================
+ Coverage   85.47%   85.48%   +0.01%     
==========================================
  Files         155      155              
  Lines       10149    10177      +28     
==========================================
+ Hits         8675     8700      +25     
- Misses       1196     1198       +2     
- Partials      278      279       +1     
Files Coverage Δ
...trollers/lifecycle/keptntask/job_runner_builder.go 100.00% <ø> (ø)
...controllers/lifecycle/keptntask/runtime_builder.go 70.44% <100.00%> (ø)
...ntrollers/lifecycle/keptntask/container_builder.go 94.91% <91.17%> (-5.09%) ⬇️
Flag Coverage Δ
certificate-operator 67.43% <ø> (ø)
component-tests 56.33% <62.85%> (+0.29%) ⬆️
lifecycle-operator 84.44% <91.42%> (+0.02%) ⬆️
metrics-operator 87.43% <ø> (ø)
scheduler 36.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Copy link

sonarcloud bot commented Nov 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bacherfl bacherfl marked this pull request as ready for review November 21, 2023 07:38
@bacherfl bacherfl requested review from a team as code owners November 21, 2023 07:38
@mowies mowies changed the title feat(lifecycle-operator)!: rename CONTEXT to KEPTN_CONTEXT in task runtimes feat(lifecycle-operator): rename CONTEXT to KEPTN_CONTEXT in task runtimes Nov 21, 2023
@bacherfl bacherfl merged commit a7322bd into keptn:main Nov 21, 2023
45 checks passed
@bacherfl bacherfl deleted the feat/rename-keptn-context-task-env-var branch November 21, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation lifecycle-operator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change context env variable name to KEPTN_CONTEXT in runtimes
3 participants