-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate testcertificate and testmetrics to chainsaw #2942
Conversation
b144016
to
1734aec
Compare
name: mockserver | ||
spec: | ||
containers: | ||
- env: |
Check warning
Code scanning / SonarCloud
CPU limits should be enforced
name: mockserver | ||
spec: | ||
containers: | ||
- env: |
Check warning
Code scanning / SonarCloud
Memory limits should be enforced
labels: | ||
app: mockserver | ||
name: mockserver | ||
spec: |
Check warning
Code scanning / SonarCloud
Service account tokens should not be mounted in pods
name: mockserver | ||
spec: | ||
containers: | ||
- env: |
Check warning
Code scanning / SonarCloud
Storage limits should be enforced
1734aec
to
02a5965
Compare
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
02a5965
to
190b1c9
Compare
test/chainsaw/testcertificate/cert-recreates/chainsaw-test.yaml
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2942 +/- ##
==========================================
+ Coverage 85.93% 85.96% +0.02%
==========================================
Files 161 161
Lines 10258 10258
==========================================
+ Hits 8815 8818 +3
+ Misses 1161 1159 -2
+ Partials 282 281 -1 see 1 file with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
e926d6f
to
216bd0d
Compare
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
216bd0d
to
61a8a5d
Compare
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks a lot @eddycharly for the awesome contribution!
I think we can tackle the issues raised by sonarcloud in a follow up :)
Thanks @thisthat ! |
|
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> Signed-off-by: shivam <shivambharadwaj822@gmail.com>
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> Signed-off-by: vickysomtee <vickysomtee@gmail.com>
Migrate
testcertificate
andtestmetrics
to chainsaw.