Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate testcertificate and testmetrics to chainsaw #2942

Merged
merged 6 commits into from
Feb 6, 2024
Merged

chore: migrate testcertificate and testmetrics to chainsaw #2942

merged 6 commits into from
Feb 6, 2024

Conversation

eddycharly
Copy link
Contributor

@eddycharly eddycharly commented Feb 1, 2024 •
edited

Migrate testcertificate and testmetrics to chainsaw.

@eddycharly eddycharly requested a review from a team as a code owner February 1, 2024 20:58
@github-actions github-actions bot added the ops label Feb 1, 2024
@eddycharly eddycharly force-pushed the chainsaw-2 branch 4 times, most recently from b144016 to 1734aec Compare February 1, 2024 21:48
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 1, 2024
View reviewed changes
test/chainsaw/testmetrics/metrics-hpa/00-install.yaml Show resolved Hide resolved
test/chainsaw/testmetrics/metrics-hpa/mock-server.yaml
name: mockserver
spec:
containers:
- env:

Check warning

Code scanning / SonarCloud

CPU limits should be enforced

<!--SONAR_ISSUE_KEY:AY1mpXYEaDGi1bfWzfLS-->Specify a CPU limit for this container. <p>See more on <a href="https://sonarcloud.io/project/issues?id=keptn_lifecycle-toolkit&issues=AY1mpXYEaDGi1bfWzfLS&open=AY1mpXYEaDGi1bfWzfLS&pullRequest=2942">SonarCloud</a></p>
test/chainsaw/testmetrics/metrics-hpa/mock-server.yaml
name: mockserver
spec:
containers:
- env:

Check warning

Code scanning / SonarCloud

Memory limits should be enforced

<!--SONAR_ISSUE_KEY:AY1mpXYEaDGi1bfWzfLT-->Specify a memory limit for this container. <p>See more on <a href="https://sonarcloud.io/project/issues?id=keptn_lifecycle-toolkit&issues=AY1mpXYEaDGi1bfWzfLT&open=AY1mpXYEaDGi1bfWzfLT&pullRequest=2942">SonarCloud</a></p>
test/chainsaw/testmetrics/metrics-hpa/mock-server.yaml
labels:
app: mockserver
name: mockserver
spec:

Check warning

Code scanning / SonarCloud

Service account tokens should not be mounted in pods

<!--SONAR_ISSUE_KEY:AY1mpXYEaDGi1bfWzfLU-->Set automountServiceAccountToken to false for this specification of kind Deployment. <p>See more on <a href="https://sonarcloud.io/project/issues?id=keptn_lifecycle-toolkit&issues=AY1mpXYEaDGi1bfWzfLU&open=AY1mpXYEaDGi1bfWzfLU&pullRequest=2942">SonarCloud</a></p>
test/chainsaw/testmetrics/metrics-hpa/mock-server.yaml
name: mockserver
spec:
containers:
- env:

Check warning

Code scanning / SonarCloud

Storage limits should be enforced

<!--SONAR_ISSUE_KEY:AY1mpXYEaDGi1bfWzfLV-->Specify a storage limit for this container. <p>See more on <a href="https://sonarcloud.io/project/issues?id=keptn_lifecycle-toolkit&issues=AY1mpXYEaDGi1bfWzfLV&open=AY1mpXYEaDGi1bfWzfLV&pullRequest=2942">SonarCloud</a></p>
@eddycharly eddycharly changed the title chore: migrate testcertificate to chainsaw chore: migrate testcertificate and testmetrics to chainsaw Feb 1, 2024
@eddycharly
chore: migrate testcertificate to chainsaw
190b1c9 
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@codecov Codecov
Copy link

codecov bot commented Feb 2, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f2d18e6) 85.93% compared to head (1a15d8c) 85.96%.

❗ Current head 1a15d8c differs from pull request most recent head 9cdf137. Consider uploading reports for the commit 9cdf137 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2942      +/-   ##
==========================================
+ Coverage   85.93%   85.96%   +0.02%     
==========================================
  Files         161      161              
  Lines       10258    10258              
==========================================
+ Hits         8815     8818       +3     
+ Misses       1161     1159       -2     
+ Partials      282      281       -1

see 1 file with indirect coverage changes

Flag Coverage Δ
certificate-operator 67.42% <ø> (ø)
component-tests 56.53% <ø> (+0.73%) ⬆️
lifecycle-operator 85.61% <ø> (ø)
metrics-operator 87.63% <ø> (ø)
scheduler 36.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@eddycharly
Merge branch 'main' into chainsaw-2
b961992 
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@eddycharly eddycharly force-pushed the chainsaw-2 branch 6 times, most recently from e926d6f to 216bd0d Compare February 2, 2024 12:28
@eddycharly
Merge branch 'main' into chainsaw-2
61a8a5d 
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@eddycharly
Merge branch 'main' into chainsaw-2
d43d12f 
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
thisthat
thisthat approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@thisthat thisthat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: LGTM! thanks a lot @eddycharly for the awesome contribution!
I think we can tackle the issues raised by sonarcloud in a follow up :)

@eddycharly
Copy link
Contributor Author

Thanks @thisthat !
Not sure why sonar complains, those files should be excluded 🤷

@eddycharly
Copy link
Contributor Author

The base branch requires all conversations on code to be resolved.

@RealAnna @thisthat can you help ?

@RealAnna RealAnna merged commit 62e667c into keptn:main Feb 6, 2024
5 checks passed
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 6, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@eddycharly eddycharly deleted the chainsaw-2 branch February 6, 2024 08:17
Bharadwajshivam28 pushed a commit to Bharadwajshivam28/lifecycle-toolkit that referenced this pull request Feb 20, 2024
@eddycharly @Bharadwajshivam28
chore: migrate testcertificate and testmetrics to chainsaw (keptn#2942)
f1d8bcc 
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: shivam <shivambharadwaj822@gmail.com>
Vickysomtee pushed a commit to Vickysomtee/keptn-lifecycle-toolkit that referenced this pull request Apr 23, 2024
@eddycharly @Vickysomtee
chore: migrate testcertificate and testmetrics to chainsaw (keptn#2942)
021df6b 
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: vickysomtee <vickysomtee@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RealAnna RealAnna RealAnna approved these changes

@thisthat thisthat thisthat approved these changes

Assignees
No one assigned
Labels
ops
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eddycharly @thisthat @RealAnna