Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AuthN does not parse JSON requests #143

Closed
cainlevy opened this issue Jan 22, 2020 · 3 comments · Fixed by #145
Closed

AuthN does not parse JSON requests #143

cainlevy opened this issue Jan 22, 2020 · 3 comments · Fixed by #145
Labels
enhancement help wanted

Comments

@cainlevy
Copy link
Member

AuthN does not parse requests with Content-Type: application/json. This can be a hurdle to getting started for folks testing the server directly without the aid of a client library.
@martinreus
Copy link
Contributor

martinreus commented Jan 26, 2020 •
edited
Loading

Regarding this issue: should the API effectively change to support both or just application/json? We probably don't want to break what is working, right?

Do you already have a rough idea in mind on how to implement this?

@cainlevy
Copy link
Member Author

I envision the API supporting both, with a Content-Type aware wrapper for reading a form param.

@martinreus
Copy link
Contributor

cool, I'll try to help with this one :)

@martinreus martinreus mentioned this issue Jan 29, 2020
Merged
@cainlevy cainlevy mentioned this issue Jul 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for application/json encoded POST/PUT/PATCH requests martinreus/authn-server
2 participants
@cainlevy @martinreus