New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Template from configuration or file #48

Merged

kernow merged 5 commits into kernow:master from toddnestor:template-from-configuration-or-file

Jun 1, 2017

Contributor

toddnestor commented Jun 1, 2017

This allows templates to be loaded from the configuration and the file system. It adds the check_config_templates_first option to the configuration so you can set whether it checks the configuration templates or the file system templates first.

It will raise an error only if it can't find a template in either place.

I can rename the check_config_templates_first easily enough if we have a better name for it. This will solve issue #47 and allow me to move forward with #46.

It doesn't directly block #46, but it would be annoying to do that first only to have to redo some of the logic because of this PR.

toddnestor added 3 commits

June 1, 2017 08:18


          Allow templates from configuration and templates to both be used

8f966ea


          Updated readme


          change where tag created for new specs

4449edb

coveralls commented Jun 1, 2017 •

edited

Loading

Coverage decreased (-0.1%) to 97.802% when pulling 8006931 on toddnestor:template-from-configuration-or-file into 93c6a4e on kernow:master.


          maybe this will pass those other ruby styles

4ede196

coveralls commented Jun 1, 2017 •

edited

Loading

Coverage decreased (-0.09%) to 97.81% when pulling 4449edb on toddnestor:template-from-configuration-or-file into 93c6a4e on kernow:master.

1 similar comment

coveralls commented Jun 1, 2017 •

edited

Loading

Coverage decreased (-0.09%) to 97.81% when pulling 4449edb on toddnestor:template-from-configuration-or-file into 93c6a4e on kernow:master.


          fixed the tests, forgot to reset some settings

576725d

coveralls commented Jun 1, 2017 •

edited

Loading

Coverage decreased (-0.1%) to 97.806% when pulling 4ede196 on toddnestor:template-from-configuration-or-file into 93c6a4e on kernow:master.

4 similar comments

coveralls commented Jun 1, 2017

Coverage decreased (-0.1%) to 97.806% when pulling 4ede196 on toddnestor:template-from-configuration-or-file into 93c6a4e on kernow:master.

coveralls commented Jun 1, 2017

Coverage decreased (-0.1%) to 97.806% when pulling 4ede196 on toddnestor:template-from-configuration-or-file into 93c6a4e on kernow:master.

coveralls commented Jun 1, 2017

Coverage decreased (-0.1%) to 97.806% when pulling 4ede196 on toddnestor:template-from-configuration-or-file into 93c6a4e on kernow:master.

coveralls commented Jun 1, 2017 •

edited

Loading

Coverage decreased (-0.1%) to 97.806% when pulling 4ede196 on toddnestor:template-from-configuration-or-file into 93c6a4e on kernow:master.

coveralls commented Jun 1, 2017 •

edited

Loading

Coverage decreased (-0.1%) to 97.786% when pulling 576725d on toddnestor:template-from-configuration-or-file into 93c6a4e on kernow:master.

Contributor Author

toddnestor commented Jun 1, 2017

Ha, finally got the tests passing. I had forgot to update the spec_helper to reset the updated configuration options.

kernow merged commit 1c56139 into kernow:master

Owner

kernow commented Jun 1, 2017

Thanks for the great work again @toddnestor, I've pushed version 1.2.0 to rubygems with your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet