-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Template from configuration or file #48
Merged
kernow
merged 5 commits into
kernow:master
from
toddnestor:template-from-configuration-or-file
Jun 1, 2017
Merged
Template from configuration or file #48
kernow
merged 5 commits into
kernow:master
from
toddnestor:template-from-configuration-or-file
Jun 1, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
4 similar comments
Ha, finally got the tests passing. I had forgot to update the |
Thanks for the great work again @toddnestor, I've pushed version 1.2.0 to rubygems with your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows templates to be loaded from the configuration and the file system. It adds the
check_config_templates_first
option to the configuration so you can set whether it checks the configuration templates or the file system templates first.It will raise an error only if it can't find a template in either place.
I can rename the
check_config_templates_first
easily enough if we have a better name for it. This will solve issue #47 and allow me to move forward with #46.It doesn't directly block #46, but it would be annoying to do that first only to have to redo some of the logic because of this PR.