Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve all dockerfiles and docker-compose.yaml #6

Open
ghost opened this issue May 28, 2023 · 0 comments
Open

Improve all dockerfiles and docker-compose.yaml #6

ghost opened this issue May 28, 2023 · 0 comments

Comments

@ghost
Copy link

ghost commented May 28, 2023

Concerns:

  1. I believe there should be a separate dockerfile for the ArangkadaDB.sqlproj to separate the responsibility for the backend Dockerfile.
  2. Frontend's Dockerfile is inconsistent if executed in a different device. Potential cause of problem: node_modules folder already existed locally and was mapped in docker-compose.yaml.
  3. Revise docker-compose.yaml for the separated sqlproj dockerfile.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants