Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript issue #19

Closed
sektr63a opened this issue Dec 23, 2023 · 3 comments
Closed

TypeScript issue #19

sektr63a opened this issue Dec 23, 2023 · 3 comments

Comments

@sektr63a
Copy link

sektr63a commented Dec 23, 2023

Current style definitions are wrong

export interface ZoomProps {
  style?: StyleProp<ViewProps>;
  contentContainerStyle?: StyleProp<ViewProps>;
  ...
}

It should be

export interface ZoomProps {
  style?: StyleProp<ViewStyle>;
  contentContainerStyle?: StyleProp<ViewStyle>;
  ...
}
@sektr63a sektr63a changed the title Typescript issue TypeScript issue Dec 23, 2023
@kesha-antonov
Copy link
Owner

Could you submit PR?

@jayan2019
Copy link

jayan2019 commented Feb 2, 2024

Also facing one more TypeScript issue
'Zoom' cannot be used as a JSX component. Its return type 'ReactNode' is not a valid JSX element. Type 'undefined' is not assignable to type 'Element | null'.ts(2786)

I think React.ReactElement will fix this instead of React.ReactNode

@onderbakirtas
Copy link

I think it can be good to mark this as closed since it seems to be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants