Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make container moving opt-in on setting page #8

Closed
jonathanKingston opened this issue Aug 18, 2017 · 5 comments
Closed

Make container moving opt-in on setting page #8

jonathanKingston opened this issue Aug 18, 2017 · 5 comments
Milestone

Comments

@jonathanKingston
Copy link

For the current page action it permits the user to move across a container boundary.

This is a risky operation that is outlined here:
https://github.com/mozilla/testpilot-containers/wiki/Moving-between-containers

@kesselborn
Copy link
Owner

oh, wow -- thanks.

If you want just tab management, this is what you want.
If you care about tracking and the security benefits of containers, this is not what you want.

I guess I was primarily thinking about tab management and took containers in as an extra but that might of course not be the case for other people ... thanks!

@jonathanKingston
Copy link
Author

No worries, let me know if you have any more questions. Looking over your extension so far the other features don't seem to break the encapsulation.

As I mentioned elsewhere, when transferring between containers you might want to consider stripping off known tracking id's like google tracking for example (this will never be perfect but could be a start).

@kesselborn
Copy link
Owner

do you already have such a warning in testpilot-containers? ... I will check later -- perhaps I could "borrow" the wording as you seem to have given quite some thought to this.
Thanks again.

@jonathanKingston
Copy link
Author

jonathanKingston commented Aug 21, 2017 via email

@kesselborn
Copy link
Owner

I'll make it an opt-in option on the settings site, so the implications can be explained accordingly.
I think stripping off some known ids will create the illusion, that we have a solution for the problem which really we haven't.
Users who don't care too much (that would be me) can then move tabs with the knowledge of the problem, others can just leave the option off.

@kesselborn kesselborn changed the title Consider adding warning for reopening container Make container moving opt-in on setting page Aug 22, 2017
@kesselborn kesselborn modified the milestones: 21, v0.0.21 Aug 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants