Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

objc macros are fairly heavy in terms of generated code. Should they be used? #33

Open
kettle11 opened this issue Sep 24, 2020 · 0 comments
Labels

Comments

@kettle11
Copy link
Owner

The events_mac file expands with cargo expand to ~3300 lines due to macros when the non-expanded version is ~660 lines.

I partially began a transition away from using the objc macros in 0d96c59 however I did not fully complete the transition. The partial reduction of the macro shaved ~6% off the build time.

However I'm now having second thoughts. Now to use new classes and selectors code must be declared in multiple additional places instead of one macro that handles it all. It makes kapp's code base aesthetically a bit messier and adds a little friction to implementing new changes.

@kettle11 kettle11 added the macOS label Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant