Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applying filter to image part #8

Closed
GoogleCodeExporter opened this issue Mar 22, 2016 · 8 comments
Closed

Applying filter to image part #8

GoogleCodeExporter opened this issue Mar 22, 2016 · 8 comments

Comments

@GoogleCodeExporter
Copy link

It is required to develop facility, which allows applying image processing 
filter to part of source image only.

Original issue reported on code.google.com by andrew.k...@gmail.com on 26 Dec 2006 at 10:54

@GoogleCodeExporter
Copy link
Author

Is this issue still open?

Would this be rectangular regions of an image (i.e. child regions), regions 
using a
binary masks or regions constructed some other way?

Original comment by mattd...@gmail.com on 29 Jun 2007 at 2:59

@GoogleCodeExporter
Copy link
Author

Yes, it is still an issue. Potentially the library allows to do this using 
Masked 
filter. But in some cases it is required to apply filter directly to specified 
rectangular region without any extra processing with masks. 

Original comment by andrew.k...@gmail.com on 30 Jun 2007 at 4:43

@GoogleCodeExporter
Copy link
Author

I've been looking through the code and I'm happy to implement the added feature 
so 
that you can apply filters directly to rectangular/child regions. Are you happy 
for 
me to go ahead and do this.

I was wondering what you though would be the best approach, what about it I 
made 
another overloaded verrsion of hte Applyfilter() funciton that takes 2 points 
as 
extra parameters, the top-left and bottom-right of the region.

Then in each filter function would use the points in it's main loop so rathern 
than

for (x = 0; x < width; x++)
    for (y = 0; y < height; y++)

if would be changed to

for (x = xStartPosn; x< xEndPosn; x++)
  for (y = xStartPosn, y< yEndPosn; y++)

I know some filters might need to work with some pixels just outside the ROI, 
to 
make sense, or maybe this could be an option.

Would this be a sensible solution or is there a better way of implementing it?

Original comment by mattd...@gmail.com on 10 Jul 2007 at 11:35

@GoogleCodeExporter
Copy link
Author

I've been thinking about similar solution. It is rather close in TODO list, 
just did 
not have time yet for it. But I would create additional interface, which should 
be 
implemented by base classes first of all and then by image processing filters. 
Potentially base classes could do some work as well (or at least do 
initialization). 
Also, don't forget that we have as "in place" filters, as filter, which produce 
new 
image ...

If you would like, you can try to this. Then I could review and merge it with 
trunk.

Original comment by andrew.k...@gmail.com on 10 Jul 2007 at 10:25

@GoogleCodeExporter
Copy link
Author

The work on this issue was start and some commits were done to source control. 
New 
IInPlacePartialFilter interface is provided and new base class for color 
filters is 
provided at this moment. Sample filters, which demonstrate the idea, are Sepia 
and 
RotateChannels.

Original comment by andrew.k...@gmail.com on 21 Aug 2007 at 4:30

  • Changed state: Started

@GoogleCodeExporter
Copy link
Author

The issue is fixed by presenting new IInPlacePartialFilter interface. New base 
classes are added. Filters, which support partial filtering, were updated to 
support 
new interface.

The list of updated filters can be found in release notes of 1.5.0 version.

Original comment by andrew.k...@gmail.com on 16 Sep 2007 at 5:16

  • Changed state: Fixed

@GoogleCodeExporter
Copy link
Author

Original comment by andrew.k...@gmail.com on 18 Feb 2008 at 12:34

  • Changed state: Verified

@GoogleCodeExporter
Copy link
Author

Original comment by andrew.k...@gmail.com on 19 May 2008 at 6:07

  • Changed state: Released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant