Make resource of certificate attributes to sensitive #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevholditch
requested changes
Mar 15, 2019
kong/resource_kong_certificate.go
Outdated
| Type: schema.TypeString, | ||
| Required: true, | ||
| ForceNew: false, | ||
| Sensitive: true, |
There was a problem hiding this comment.
@caryyu why does the public key need to be sensitve?
There was a problem hiding this comment.
You're right, I modified and only the private key should be sensitive
kevholditch
approved these changes
Apr 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, we should set the certificate to sensitive to avoid the output causing security policy concerns, Issued by #65