Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class problem when same icon is used multiple times on the same page #26

Open
ghost opened this issue Jul 5, 2018 · 3 comments
Open

Comments

@ghost
Copy link

ghost commented Jul 5, 2018

Hi,

I think there is a problem when a same icon is used multiple times on the same page.

If I use this code :
{!! FA::icon('times') !!} {!! FA::icon('times') !!} {!! FA::icon('times') !!} {!! FA::icon('times') !!}

The first cross will be correctly displayed, but not the three others :
Cross not correctly displayed

The bug is linked to a problem in the source code : the "fas" class is missing in the three last crosses :
<i class="fas fa-times"></i> <i class=" fa-times"></i> <i class=" fa-times"></i> <i class=" fa-times"></i>

Source code with fas missing

And when is add the "fas" class manually in my Chrome, of course, it works.

Is this problem already known ?
How can we fix this ?

Thanks !

@kevinkhill
Copy link
Owner

I don't have time to work on this, but after a quick glance through the code, I think it might be as easy as changing this line to $this->style = 'fas';

Could you see if that works? And if it does, can you open a pull request to fix it for me?

@kevinkhill
Copy link
Owner

This is fixed now, ya?

@gammaire
Copy link

Hi,
The issue does not look like to be fixed. It does the same thing for me and I'm not even using the same icons:
<i class="fas fa-code"></i> <i class=" fa-user"></i>
Regards,
Andras

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants