Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with compiling the source code #82

Open
romanzenka opened this issue Jun 20, 2023 · 1 comment
Open

Issues with compiling the source code #82

romanzenka opened this issue Jun 20, 2023 · 1 comment

Comments

@romanzenka
Copy link

I have cloned your repository to a Windows 11 machine with Visual Studio Professional 2022 (17.5.1) and ran into multiple issues when compiling.

  1. NuGet packages for Thermo do not seem to be available (possibly because you use a local NuGet for your purposes)
  2. CLParserForNetFramework package is no longer maintained/available, suggested replacement CommandLineParser has different API
  3. SearchMetricsContainer cannot be serialized because it does not have no-parameter constructor

I overcame all these problems by downloading Thermo DLLs directly, changing the command line parsing (sadly new parser does not support "short" switches that are multiple characters long, so that interface changed for me) and adding an empty constructor, and the tool seems to be working now.

I would be curious to know if you'd be interesting in "sprucing up" the codebase, so it compiles out of the box in the changed software landscape. I can make a pull request if you want, but since I changed the interface, I probably need to put more work in to make it a drop-in replacement.

Thank you!

Desktop & RawTools information:

  • OS: Windows 11
  • RawTools version: 2.0.4 (as per VersionInfo)
  • Commit: c1ceb61
@chrishuges
Copy link
Collaborator

Hi @romanzenka,

Sorry you had these issues, but I am glad you were able to sort it out. I haven't had a chance to work on RawTools in some time. Over the next few months I will be changing positions to a new role where I will have a lot of time that I plan to devote to, among other things, debugging and adding new features to RawTools. I would be happy to have you contribute in any way you see fit, if you are interested!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants