Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: changed date-format, camelCase instead of snake_case, null values, update and create for customer and project #718

Merged
merged 35 commits into from
Apr 24, 2019
Merged

API: changed date-format, camelCase instead of snake_case, null values, update and create for customer and project #718

merged 35 commits into from
Apr 24, 2019

Conversation

kevinpapst
Copy link
Member

@kevinpapst kevinpapst commented Apr 20, 2019 •
edited
Loading

Description

Fixes #701

  • API docs show now the real result structures, different for entity and collection requests
  • Results include null fields ALWAYS, previously they were not included in the JSON
  • changed/fixed Datetime handling:
    • returns ISO 8601 Datetime strings
    • expects HTML5 "local date and time" format
  • switch from snake_case to camelCase
  • require PHP 7.2

For the updated Datetime handling, see the documentation update at kimai/www.kimai.org#25

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

The Datetime changes likely introduce a BC break.

Checklist

  • I have executed bin/console kimai:phpcs --fix to make sure my changes adopt the correct code style
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I agree that this code is used in Kimai and will be published under the MIT license

@kevinpapst kevinpapst added this to the 0.9 milestone Apr 20, 2019
@kevinpapst kevinpapst changed the title use correct serialization groups in collection calls serialize null values and use correct serialization groups Apr 20, 2019
@kevinpapst kevinpapst changed the title serialize null values and use correct serialization groups API: serialize null values, use correct serialization groups, fix dates Apr 22, 2019
@kevinpapst kevinpapst mentioned this pull request Apr 22, 2019
Merged
@kevinpapst kevinpapst changed the title API: serialize null values, use correct serialization groups, fix dates API: datchanged date-format, camelCase instead of snake case, null values, new update and create for all entities Apr 23, 2019
@kevinpapst kevinpapst changed the title API: datchanged date-format, camelCase instead of snake case, null values, new update and create for all entities API: changed date-format, camelCase instead of snake case, null values, update and create for customer and project Apr 23, 2019
@kevinpapst kevinpapst changed the title API: changed date-format, camelCase instead of snake case, null values, update and create for customer and project API: changed date-format, camelCase instead of snake_case, null values, update and create for customer and project Apr 23, 2019
@kevinpapst kevinpapst merged commit 4603911 into master Apr 24, 2019
@kevinpapst kevinpapst deleted the api-doc-results branch April 24, 2019 16:13
@lock
Copy link

lock bot commented Jun 23, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. If you use Kimai on a daily basis, please consider donating to support further development of Kimai.

@lock lock bot locked and limited conversation to collaborators Jun 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
API feature request
Projects
None yet
Milestone
0.9
Development

Successfully merging this pull request may close these issues.

API docs are wrong for GET entity (ignores serialization group)
1 participant
@kevinpapst